Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: null value not persisted for JSON, Any, Object types (v4) #1899

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

achrinza
Copy link
Member

@achrinza achrinza commented Aug 28, 2021

I don't have enough familiarity with the codebase to write the necessary tests; We can put it into the backlog or someone else can help write and push some tests onto this branch :)

fixes #1895

Signed-off-by: Rifa Achrinza [email protected]

Checklist

  • Sign off your commits with DCO (Developer Certificate of Origin)
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@achrinza achrinza requested a review from dhmlau as a code owner August 28, 2021 13:12
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1226264821

  • -4 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.02%) to 84.733%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dao.js 0 4 0.0%
Totals Coverage Status
Change from base Build 1223745102: -0.02%
Covered Lines: 7159
Relevant Lines: 8150

💛 - Coveralls

@coveralls
Copy link

coveralls commented Sep 12, 2021

Pull Request Test Coverage Report for Build 1226264821

  • 0 of 4 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 84.741%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/dao.js 0 4 0.0%
Totals Coverage Status
Change from base Build 1223745102: -0.01%
Covered Lines: 7159
Relevant Lines: 8150

💛 - Coveralls

@stale
Copy link

stale bot commented Nov 11, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 11, 2021
@siimsams
Copy link
Contributor

We have the same issue. This solves it. What is needed for this to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

null value not persisted for properties of type JSON, Any, or Object
4 participants