Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add values to enum type #598

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Jul 10, 2024

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz aaqilniz force-pushed the fix/enum-values branch 2 times, most recently from 0a3f60f to d47460c Compare August 24, 2024 20:29
Signed-off-by: Muhammad Aaqil <[email protected]>
@aaqilniz aaqilniz marked this pull request as ready for review August 25, 2024 17:48
@aaqilniz
Copy link
Contributor Author

Hi, @dhmlau. One of the tests is failing for some reason. There is no direct/indirect change to the failing test case. I tried for a while but can't figure it out.

Can you please have a look whenever you have the chance?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant