Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: discover properties with json type #588

Merged
merged 1 commit into from
May 23, 2024

Conversation

aaqilniz
Copy link
Contributor

While discovering the properties, the connector assigns default type to a JSON typed property. This PR fixes that.

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@aaqilniz aaqilniz marked this pull request as ready for review May 21, 2024 10:55
Copy link
Member

@dhmlau dhmlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dhmlau dhmlau merged commit 77b2c40 into loopbackio:master May 23, 2024
5 checks passed
@dhmlau
Copy link
Member

dhmlau commented May 23, 2024

@aaqilniz, thanks for your PR!

@aaqilniz aaqilniz deleted the fix/discover-json-type branch August 17, 2024 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants