fix: enable migration for enum property #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
fix/migration-for-enum
branch
from
f10ae9f
to
3d0dd5f
Compare
dhmlau
reviewed
Jun 3, 2024
lib/migration.js
Outdated
| if (colType && colType === 'ENUM') { | ||
| if (prop.jsonSchema && prop.jsonSchema.enum) { | ||
| prop.jsonSchema.enum.forEach(item => { | ||
| enumList += `'${item}'`; |
There was a problem hiding this comment.
do we need some separators like , to separate each enum value?
There was a problem hiding this comment.
@dhmlau. You are right. Thanks for pointing out. Fixed it.
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/migration-for-enum
branch
from
7ec1284
to
9c29822
Compare
samarpanB
approved these changes
Sep 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm testpasses on your machine