feat: add mysql8 support, update to mysql2 client, drop nodejs v14 and mysql5.7 support [BREAKING CHANGE] #484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@samarpanB, since you're working on a breaking change, could you please also drop the support for Node.js 14 which reaches end of life already? Thanks! |
samarpanB
force-pushed
the
gh-477
branch
2 times, most recently
from
620581e
to
45d6f0e
Compare
samarpanB
changed the title
This was referenced Jun 26, 2023
samarpanB
force-pushed
the
gh-477
branch
9 times, most recently
from
29f0641
to
9411e86
Compare
… and mysql5.7 support BREAKING CHANGE drop mysql5.7 support Signed-off-by: Samarpan Bhattacharya <[email protected]>
mschnee
approved these changes
Jun 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mysql8 support and change to mysql2 client library
BREAKING CHANGE
update mysql client to mysql2 client as that support new authentication protocol of mysql 8
drop mysql5.7 support
drop nodejs v14 support
MySQL 5.7 EOL is in October 2023 - https://endoflife.software/applications/databases/mysql. So we will only keep it for security updates in separate branch.
@achrinza @dhmlau any specific approach to be taken for that, please let me know.
Fixes #477 , #434, #468
Checklist
npm testpasses on your machine