Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: include using parent fields projection #649

Open
wants to merge 1 commit into
base: 5.x
Choose a base branch
from

Conversation

mCassanoNsi
Copy link

Fixes #648

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Oct 28, 2021

Pull Request Test Coverage Report for Build 86

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 81.007%

Totals Coverage Status
Change from base Build 78: 0.0%
Covered Lines: 913
Relevant Lines: 1061

💛 - Coveralls

@darknos
Copy link
Contributor

darknos commented Feb 7, 2022

Hi. Great job. I confirm the issue, but I'd suggest smaller solution. Please look at this commit:

darknos@1cd3cda

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants