Merge pull request #39 from looker/jim/v1_common_fix

Put highcharts in its own file
looker · Aug 23, 2018 · b472a23 · b472a23
2 parents a64be99 + 0b52715
commit b472a23
Show file tree

Hide file tree

Showing 11 changed files with 13 additions and 14 deletions.
diff --git a/dist/chord.js b/dist/chord.js
diff --git a/dist/collapsible_tree.js b/dist/collapsible_tree.js
diff --git a/dist/hello_world.js b/dist/hello_world.js
diff --git a/src/common/highcharts.js → dist/highcharts.js b/src/common/highcharts.js → dist/highcharts.js
diff --git a/dist/liquid_fill_gauge.js b/dist/liquid_fill_gauge.js
diff --git a/dist/sankey.js b/dist/sankey.js
diff --git a/dist/subtotal.js b/dist/subtotal.js
diff --git a/dist/sunburst.js b/dist/sunburst.js
diff --git a/dist/treemap.js b/dist/treemap.js
diff --git a/dist/v1_common.js b/dist/v1_common.js
diff --git a/src/common/common-entry.js b/src/common/common-entry.js
@@ -76,7 +76,6 @@ function handleErrors(vis, resp, options) {
   return true;
 }
 
-global.d3v4 = require('./d3.v4')
-global.Highcharts = require('./highcharts')
-global.formatType = formatType
-global.handleErrors = handleErrors
+window.d3v4 = require('./d3.v4')
+window.formatType = formatType
+window.handleErrors = handleErrors