feat(sort): Adding sorting on clicking column header #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Itzaprado
force-pushed
the
itzaprado/FR-306401843-table-report
branch
from
3d72bc6 to
dd3d4aa
Compare
RexGibson
reviewed
Dec 6, 2024
| // Here goes the sorting then the vis is built again | ||
| // If order = true => ascending | ||
| // If order = false => descending | ||
| const updateSorting = (order, key, pivot) => { |
There was a problem hiding this comment.
I've not deeply looked at this but I wanted to understand if this is following the traditional looker behavior that the sort is done on the client if the results are less than the limit but if the results are more than the limit then the sort has to re run the query first?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change log:
[ ] Sort function added on clicking on column header
[ ] Add validation to apply sorting when is not a transposed table