Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate SDKs for Looker 24.4 #1442

Merged
merged 1 commit into from
Mar 12, 2024
Merged

feat: generate SDKs for Looker 24.4 #1442

merged 1 commit into from
Mar 12, 2024

Conversation

drstrangelooker
Copy link
Collaborator

Release-As: 24.4.0

@drstrangelooker drstrangelooker requested a review from a team as a code owner March 12, 2024 22:03
Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this passes CI it's fine for us but I'm concerned about the breaking change in the API

/// <summary>Json query results (read-only)</summary>
public string[] data { get; set; } = null;
public string[] rows { get; set; } = null;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenvlooker do we have documentation about this breaking API change?

Copy link
Contributor

Go Tests

    6 files      6 suites   4m 39s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit 6ab1c38.

Copy link
Contributor

Python Tests

    9 files  ±0      9 suites  ±0   1m 46s ⏱️ +4s
144 tests ±0  139 ✔️ ±0    5 💤 ±0  0 ❌ ±0 
676 runs  ±0  657 ✔️ ±0  19 💤 ±0  0 ❌ ±0 

Results for commit 6ab1c38. ± Comparison against base commit 21daada.

Copy link
Contributor

Typescript Tests

  10 files    64 suites   6m 59s ⏱️
227 tests 223 ✔️   4 💤 0 ❌
656 runs  624 ✔️ 32 💤 0 ❌

Results for commit 6ab1c38.

@drstrangelooker drstrangelooker merged commit a05b8df into main Mar 12, 2024
44 checks passed
@drstrangelooker drstrangelooker deleted the sdk_24_4 branch March 12, 2024 22:14

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants