always send feedback for postgres replication messages #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MattExact
commented
May 22, 2024
Comment on lines
89
to
94
| def _consumer(self, msg: ReplicationMessage): | ||
| payload = json.loads(msg.payload) | ||
| changes = payload.get("change") | ||
| if not changes: | ||
| return | ||
| next_lsn = payload["nextlsn"] | ||
|
|
||
| changes = payload.get("change", []) | ||
| for change in changes: |
There was a problem hiding this comment.
I reworked quite a bit of this for neatness, hope that's okay!
The primary change was to payload.get("change", []) so that it doesn't early return.
I also changed payload.get("nextlsn") to payload["nextlsn"], AFAIK there will always be a nextlsn.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My previous PR partially fixed the Postgres disk usage issue #84
It was pointed out that for idle databases the disk use was still growing.
I believe that this is because it's not always sending feedback for replication messages, and only does so when there's a change to a table for a Meilisync index.
If instead we always send feedback, then it should allow Postgres to free WAL segments on idle databases.