v1.1.17 - Fix bug in ICD of Sextant and Elder Scribes

lologarithm · Sep 4, 2021 · ced25d9 · ced25d9
1 parent 9dcc77b
commit ced25d9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 7 deletions.
diff --git a/tbc/auras.go b/tbc/auras.go
@@ -660,16 +660,17 @@ func ActivateIED(sim *Simulation) Aura {
 
 func ActivateMSD(sim *Simulation) Aura {
 	const hasteBonus = 320.0
-	const dur = time.Second * 35
+	const dur = time.Second * 4
+	const icdDur = time.Second * 35
 	icd := NewICD()
 	return Aura{
 		ID:      MagicIDMysticSkyfire,
 		Expires: neverExpires,
 		OnCastComplete: func(sim *Simulation, c *Cast) {
 			if !icd.isOnCD(sim) && sim.rando.Float64() < 0.15 {
-				icd = InternalCD(sim.CurrentTime + dur)
+				icd = InternalCD(sim.CurrentTime + icdDur)
 				sim.Stats[StatHaste] += hasteBonus
-				sim.addAura(AuraStatRemoval(sim.CurrentTime, time.Second*4, hasteBonus, StatHaste, MagicIDMysticFocus))
+				sim.addAura(AuraStatRemoval(sim.CurrentTime, dur, hasteBonus, StatHaste, MagicIDMysticFocus))
 			}
 		},
 	}
@@ -919,8 +920,8 @@ func ActivateSextant(sim *Simulation) Aura {
 		ID:      MagicIDSextant,
 		Expires: neverExpires,
 		OnSpellHit: func(sim *Simulation, c *Cast) {
-			if !icd.isOnCD(sim) && c.DidCrit && sim.rando.Float64() < 0.2 {
-				icd = InternalCD(sim.CurrentTime + dur)
+			if c.DidCrit && !icd.isOnCD(sim) && sim.rando.Float64() < 0.2 {
+				icd = InternalCD(sim.CurrentTime + icdDur)
 				sim.Stats[StatSpellDmg] += spellBonus
 				sim.addAura(AuraStatRemoval(sim.CurrentTime, dur, spellBonus, StatSpellDmg, MagicIDUnstableCurrents))
 			}
@@ -960,7 +961,7 @@ func ActivateElderScribes(sim *Simulation) Aura {
 		OnSpellHit: func(sim *Simulation, c *Cast) {
 			// This code is starting to look a lot like other ICD buff items. Perhaps we could DRY this out.
 			if !icd.isOnCD(sim) && sim.rando.Float64() < proc {
-				icd = InternalCD(sim.CurrentTime + dur)
+				icd = InternalCD(sim.CurrentTime + icdDur)
 				sim.Stats[StatSpellDmg] += spellBonus
 				sim.addAura(AuraStatRemoval(sim.CurrentTime, dur, spellBonus, StatSpellDmg, MagicIDElderScribeProc))
 			}

diff --git a/ui/index.html b/ui/index.html
@@ -332,7 +332,7 @@ <h4>Standard Elemental Build</h4>
         <div id="pullout">
             <div class="dtl" style="height:100%;width:100%;padding:10px">
                 <div id="themetoggle" style="height:20px; bottom: 10px; cursor: pointer;" onclick="toggletheme()">
-                    <text>v1.1.16</text>
+                    <text>v1.1.17</text>
                     <img id="themebulb" style="height: 20px; width: 20px" src="icons/light-bulb.svg"></img>
                 </div>
                 <div style="margin-top:10px">

diff --git a/ui/lib.wasm b/ui/lib.wasm