Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LeagueItem is broken #56

Open
dnlbauer opened this issue May 22, 2016 · 1 comment · May be fixed by #57
Open

LeagueItem is broken #56

dnlbauer opened this issue May 22, 2016 · 1 comment · May be fixed by #57

Comments

@dnlbauer
Copy link
Contributor

All leauge items in the List returned from ApiHandler#getLeagueEntries are empty. The only value set in them is tier. All other variables are either 0 or null. Also getRank() and getQueueType() are throwing exceptions because of that.
@dnlbauer
Copy link
Contributor Author

dnlbauer commented May 22, 2016 •
edited
Loading

Problem seems to be the wrong return time. The api is actually returning a <Map<Long, List<LeagueList>>> while riotapi.rest tries to parse a <Map<Long, List<LeagueEntry>>> at ApiHandler line 236. Replacing LeagueEntry with LeagueList fixes the problem.

@dnlbauer dnlbauer linked a pull request May 22, 2016 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix ApiHandler#getLeagueEntries
1 participant
@dnlbauer