-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DIAL, DLBR, INFO, PACK Records & More!!~~ #17
base: master
Are you sure you want to change the base?
Conversation
…t ), XOWN ( simple formid ) chunks for CELL, fix to CTDA::VisitFormIDs() Function_Arguments typo, MODL chunk added to WRLD, GENMNAM is now 28 bytes struct ( up from 16 ), including the 1.8 changes to this struct.
Thanks for the work, I will request a few things from you however:
Doing this will make it much easier to review, and then I can merge in chunks as I get them reviewed. Not only that, but if I find issue with one part of it, when it's all lumped into one PR, none of it gets merged, instead of just the small PR with the issue. Other than that nitpicky stuff, the only issue with it I see is the GENMNAM changes: |
Shouldn't DLBR be incorporated into one pull request with DIALs and INFOs as they are a related topic? About MNAM, it's okay, I will just create a new structure and revert back MNAM ( even though I was almost certain that even if the structure is bigger, it won't make a difference ). Tnx :) |
DLBR: you're right, I forgot that Skyrim added new dialog related record types. Although now we're getting up into quite a bit of code in one PR. I'd prefer split PRs there, but up to you really. MNAM: for reading in the structure it won't cause a problem for Oblivion/FNV, however when writing out the record it would, since it would end up writing the larger version. Not 100% sure how each of the game engines would handle it: for example Skyrim is pretty resilient when it comes to miss-sized subrecords, but Oblivion would usually crash. Either case though, better to have the tool (CBash) do it correctly than to rely on something like that. |
Hi, Will let you guys know when I'll start working on it. |
That's fine, I'll probably pick out the bug fix and do it manually. I'd like to say if I get time I'll review the rest and merge it, but more likely I just won't have the time, life's busy. I will leave the PR open though, so if you ever get back to it you can split things up, or if I find the time I can handle it. |
Original commit message:
XOWN ( simple formid ) chunks for CELL, fix to CTDA::VisitFormIDs()
Function_Arguments typo, MODL chunk added to WRLD, GENMNAM is now 28 bytes struct ( up from 16 ), including the 1.8 changes to this struct.
Detailed description:
This was done as a helping API for Skyblivion project, thus API might not be ideal ( I'm not really that familiar with this lib ). It adds some new neat records though, so I suppose you might like to take a look :)