feat(experience): handle secondary sign-up identifiers #7142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
COMPARE TO
|
| Name | Diff |
|---|---|
| .changeset/purple-waves-sit.md | 📉 -886 Bytes |
| Dockerfile | 📉 -212 Bytes |
| packages/console/src/assets/images/recaptcha.svg | 📉 -1.49 KB |
| packages/console/src/assets/images/turnstile.svg | 📉 -1.39 KB |
| packages/console/src/components/Drawer/index.tsx | 📉 -177 Bytes |
| packages/console/src/components/Region/index.tsx | 📉 -486 Bytes |
| packages/console/src/components/Topbar/TenantSelector/TenantDropdownItem/index.tsx | 📉 -28 Bytes |
| packages/console/src/consts/env.ts | 📉 -102 Bytes |
| packages/console/src/hooks/use-console-routes/routes/security.tsx | 📉 -229 Bytes |
| packages/console/src/pages/CaptchaDetails/CaptchaContent/index.tsx | 📉 -2.81 KB |
| packages/console/src/pages/CaptchaDetails/index.module.scss | 📉 -154 Bytes |
| packages/console/src/pages/CaptchaDetails/index.tsx | 📉 -4.67 KB |
| packages/console/src/pages/Security/CaptchaCard/index.module.scss | 📉 -250 Bytes |
| packages/console/src/pages/Security/CaptchaCard/index.tsx | 📉 -1.12 KB |
| packages/console/src/pages/Security/CaptchaLogo/index.module.scss | 📉 -163 Bytes |
| packages/console/src/pages/Security/CaptchaLogo/index.tsx | 📉 -384 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/ProviderRadioGroup/ProviderRadio/index.module.scss | 📉 -533 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/ProviderRadioGroup/ProviderRadio/index.tsx | 📉 -801 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/ProviderRadioGroup/index.module.scss | 📉 -119 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/ProviderRadioGroup/index.tsx | 📉 -923 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/constants.ts | 📉 -821 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/index.module.scss | 📉 -113 Bytes |
| packages/console/src/pages/Security/CreateCaptchaForm/index.tsx | 📉 -1.29 KB |
| packages/console/src/pages/Security/CreateCaptchaForm/types.ts | 📉 -294 Bytes |
| packages/console/src/pages/Security/index.tsx | 📉 -733 Bytes |
| packages/console/src/pages/Security/use-data-fetch.ts | 📉 -765 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/ConsoleEmbeddedPricing/Skeleton/index.module.scss | 📉 -463 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/ConsoleEmbeddedPricing/Skeleton/index.tsx | 📉 -706 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/ConsoleEmbeddedPricing/index.module.scss | 📉 -185 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/ConsoleEmbeddedPricing/index.tsx | 📉 -4.24 KB |
| packages/console/src/pages/TenantSettings/Subscription/SwitchPlanActionBar/index.module.scss | 📉 -37 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/SwitchPlanActionBar/index.tsx | 📉 -10 Bytes |
| packages/console/src/pages/TenantSettings/Subscription/index.tsx | 📉 -139 Bytes |
| packages/console/src/pages/TenantSettings/TenantBasicSettings/ProfileForm/TenantRegion/index.tsx | 0 Bytes |
| packages/console/vite.config.ts | 📉 -122 Bytes |
| packages/core/src/libraries/sign-in-experience/sign-in.test.ts | 📉 -2.54 KB |
| packages/core/src/libraries/sign-in-experience/sign-in.ts | 📉 -908 Bytes |
| packages/core/src/libraries/sign-in-experience/sign-up.test.ts | 📉 -3.24 KB |
| packages/core/src/libraries/sign-in-experience/sign-up.ts | 📉 -2.2 KB |
| packages/core/src/routes/experience/classes/libraries/sign-in-experience-validator.test.ts | 📉 -3.73 KB |
| packages/core/src/routes/experience/classes/libraries/sign-in-experience-validator.ts | 📉 -1.76 KB |
| packages/core/src/routes/sign-in-experience/index.ts | 📉 -46 Bytes |
| packages/experience/src/components/IdentifierRegisterForm/use-register-with-username.ts | 📉 -1.15 KB |
| packages/experience/src/constants/env.ts | 📉 -149 Bytes |
| packages/experience/src/containers/VerificationCode/use-register-flow-code-verification.ts | 📉 -283 Bytes |
| packages/experience/src/containers/VerificationCode/use-sign-in-flow-code-verification.ts | 📉 -44 Bytes |
| packages/experience/src/hooks/use-sie.ts | 📉 -4.14 KB |
| packages/experience/src/pages/RegisterPassword/index.tsx | 📉 -38 Bytes |
| packages/experience/src/pages/VerificationCode/index.tsx | 📉 -75 Bytes |
| packages/experience/vite.config.ts | 📉 -464 Bytes |
| packages/integration-tests/src/tests/api/experience-api/register-interaction/username-password.test.ts | 📉 -2.08 KB |
| packages/integration-tests/src/tests/api/experience-api/register-interaction/verification-code.test.ts | 📉 -2.36 KB |
| packages/integration-tests/src/tests/api/sign-in-experience.test.ts | 📉 -93 Bytes |
| packages/phrases/src/locales/en/errors/sign-in-experiences.ts | 📉 -155 Bytes |
| packages/phrases/src/locales/en/translation/admin-console/security.ts | 📉 -1.06 KB |
| packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts | 📉 -1.88 KB |
refactor the verification code sign-in and sign-up error handling logic.
simeng-li
force-pushed
the
simeng-log-10932-experience-update-the-experience-sign-up-form-render-logic
branch
from
7525149 to
7d4b428
Compare
remove verification code method assertion
fix ut
add some comments
update username registraction handler, directly submit the interaction is password is not enabled for sign-up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the use-sie hook to merge signUp.identifiers and signUp.secondaryIdentifiers. The combined list can be used to render the user registration form.
Testing
test locally
Checklist
.changeset