Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): parse mandatory profile #7133

Open
wants to merge 1 commit into
base: simeng-log-10897-schemas-update-sie-schema-to-support-multiple-sign-up
Choose a base branch
from

Conversation

simeng-li
Copy link
Contributor

Summary

Refactor the getMandatoryUserProfileBySignUpMethods method to parse mandatory user profiles from both signUp.identifiers and newly added signUp.secondaryIdentifiers.

Testing

UT case added

Checklist

  • .changeset
  • unit tests
  • integration tests
  • necessary TSDoc comments

Copy link

github-actions bot commented Mar 13, 2025

COMPARE TO master

Total Size Diff ⚠️ 📈 +14.89 KB

Diff by File
Name Diff
.changeset/purple-waves-sit.md 📈 +886 Bytes
packages/core/src/libraries/sign-in-experience/sign-in.test.ts 📈 +2.54 KB
packages/core/src/libraries/sign-in-experience/sign-in.ts 📈 +908 Bytes
packages/core/src/libraries/sign-in-experience/sign-up.test.ts 📈 +3.24 KB
packages/core/src/libraries/sign-in-experience/sign-up.ts 📈 +2.2 KB
packages/core/src/routes/experience/classes/libraries/sign-in-experience-validator.test.ts 📈 +3.73 KB
packages/core/src/routes/experience/classes/libraries/sign-in-experience-validator.ts 📈 +1.76 KB
packages/core/src/routes/sign-in-experience/index.ts 📈 +46 Bytes
packages/integration-tests/src/tests/api/experience-api/register-interaction/username-password.test.ts 📈 +2.08 KB
packages/integration-tests/src/tests/api/experience-api/register-interaction/verification-code.test.ts 📈 +2.36 KB
packages/integration-tests/src/tests/api/sign-in-experience.test.ts 📈 +93 Bytes
packages/phrases/src/locales/en/errors/sign-in-experiences.ts 📈 +155 Bytes
packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts 📈 +1.88 KB

@github-actions github-actions bot added feature Cool stuff size/m labels Mar 13, 2025
@github-actions github-actions bot added size/l and removed size/m labels Mar 13, 2025
@simeng-li simeng-li requested review from a team March 13, 2025 10:33
@simeng-li simeng-li force-pushed the simeng-log-10897-schemas-update-sie-schema-to-support-multiple-sign-up branch 2 times, most recently from 765188f to c7a575b Compare March 14, 2025 09:10
parse mandatory profile
@simeng-li simeng-li force-pushed the simeng-log-10890-experience-api-update-registration-event-to-handle-multiple branch from 901d583 to dfe66bf Compare March 14, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants