-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core,schemas): add secondary sign-up identifiers #7127
base: master
Are you sure you want to change the base?
feat(core,schemas): add secondary sign-up identifiers #7127
Conversation
COMPARE TO
|
Name | Diff |
---|---|
.changeset/purple-waves-sit.md | 📈 +886 Bytes |
packages/core/src/libraries/sign-in-experience/sign-in.test.ts | 📈 +2.54 KB |
packages/core/src/libraries/sign-in-experience/sign-in.ts | 📈 +908 Bytes |
packages/core/src/libraries/sign-in-experience/sign-up.test.ts | 📈 +3.24 KB |
packages/core/src/libraries/sign-in-experience/sign-up.ts | 📈 +2.2 KB |
packages/core/src/routes/sign-in-experience/index.ts | 📈 +46 Bytes |
packages/integration-tests/src/tests/api/sign-in-experience.test.ts | 📈 +93 Bytes |
packages/phrases/src/locales/en/errors/sign-in-experiences.ts | 📈 +155 Bytes |
packages/schemas/src/foundations/jsonb-types/sign-in-experience.ts | 📈 +1.88 KB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests failed.
dc24f72
to
427203c
Compare
427203c
to
765188f
Compare
add secondaryIdentifiers to SIE signUp settings
765188f
to
c7a575b
Compare
add changeset
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm on changeset
"@logto/core": patch | ||
--- | ||
|
||
remove some SIE sign-in and sign-up settings restrictions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove some SIE sign-in and sign-up settings restrictions | |
remove multiple sign-in experience settings restrictions |
|
||
remove some SIE sign-in and sign-up settings restrictions | ||
|
||
For better customization flexibility, we have removed following restrictions on the SIE sign-in and sign-up settings: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better customization flexibility, we have removed following restrictions on the SIE sign-in and sign-up settings: | |
For better customization flexibility, we have removed following restrictions in the sign-in experience "sign-in and sign-up" settings: |
Note: If username is the only sign-up identifier, users without a password will not be able to sign in. Developers or administrators should carefully configure the sign-up and sign-in settings to ensure a smooth user experience. | ||
Users can still set password via [account API](https://docs.logto.io/end-user-flows/account-settings/by-account-api) after sign-up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: If username is the only sign-up identifier, users without a password will not be able to sign in. Developers or administrators should carefully configure the sign-up and sign-in settings to ensure a smooth user experience. | |
Users can still set password via [account API](https://docs.logto.io/end-user-flows/account-settings/by-account-api) after sign-up. | |
Note: If username is the only sign-up identifier, users without a password will not be able to sign in. Developers or administrators should carefully configure the sign-up and sign-in settings to ensure a smooth user experience. | |
Users can still set password via [account API](https://docs.logto.io/end-user-flows/account-settings/by-account-api) after sign-up. |
Summary
Enhance sign-up identifier settings to support additional identifiers.
Context
Previously, only one type of identifier could be collected during the sign-up process. The existing sign-up identifier settings in SIE included four options:
username
,email
,phone
, andemailOrPhone
.This update allows developers to require multiple identifiers for user sign-up, such as combinations like
username + email
,username + emailOrPhone
, andusername + email + phone
.Key updates (dev feature)
secondaryIdentifiers
, has been introduced to the SIEsignUp
settings. All identifiers listed in this new field will be treated as additional required identifiers that users must provide during the sign-up process.signUp.identifiers
field remains unchanged and will continue to be used as the primary sign-up identifier when rendering the sign-up form.secondaryIdentifiers
will be validated after the primary sign-up identifiers are provided, ensuring a smooth transition for existing implementations.Refactor sign-up and sign-in settings rules (changeset included)
We have fully decoupled the sign-up identifier settings from the sign-in methods. Developers can now require as many user identifiers as needed during the sign-up process without impacting the sign-in process.
The following restrictions on sign-in and sign-up settings have been removed:
The
password
field in sign-up settings is no longer required whenusername
is included as one of the sign-up identifiers (either primary or secondary). Developers may request ausername
without requiring a password during the sign-up process.Note: If
username
is the only sign-up identifier, users without a password will not be able to sign in. Developers or administrators should carefully configure the sign-up and sign-in settings to ensure a smooth user experience.The requirement that all sign-up identifiers must also be enabled as sign-in identifiers has been removed.
Testing
UT case updated
Checklist
.changeset