-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: ECS compatibility (RFC email fields) #56
base: main
Are you sure you want to change the base?
Conversation
due `lowercase_headers => true` default
otherwise a potential nil.to_s would never be nil
I wonder if it makes sense to differentiate here between I am concerned about the transition, of users who update this plugin and begin using ECS mode now, only to consume an upgrade at some point in the near future and have defaults change out of under them. Planning a transition for these users will take some care, and I will think about that in the next day or so. |
would prefer to support one thing but this gets messy - if we would to strictly follow the logic:
yeah so changing the defaults (switching to no
atm, given the RFC nature of |
ATM, this PR extends #55 and support for ECS (unreleased)
email.*
fields using atarget => [email]
default in ECS mode.Current DIFF from PR #55
There's a few extra bits that make sense from a user perspective having the
email
fields in ECS mode:headers_target => ''
attachments_target => ''
This PR will need a review once the
email
RFC is pushed, there's a few items to implement/consider :[email][from]
into[email][from][address]
(breaking ECS compatibility)headers_target => '[@metadata][input][imap][headers]'
default is ECS mode?attachments_target => '[@metadata][input][imap][attachments]'
default is ECS mode?