Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: change ComponentProfile 'total' property to 'usage' #53

Conversation

kittisakLS
Copy link
Contributor

@kittisakLS kittisakLS commented Nov 7, 2023

Overview

This PR addresses issue #52 , which involves changing the 'total' property in the ComponentProfile to 'usage'. The transformation of this property is crucial for improving clarity and relevancy of the VueScanner's functionality.

Changes

  1. In the scanner module, the reviseGroupedComponentSources function has been added to support the renaming of the 'total' property to 'usage'.
  2. The 'usageLocation' module has been updated to ensure the correct preparation of usage location data.
  3. Unused code lines have been removed from the module.utils.ts to maintain code cleanliness.

The modifications will provide more accurate information in the ComponentProfile and enhance the overall usability of the VueScanner.

Closing Notes

@kittisakLS kittisakLS requested a review from ravut8 November 7, 2023 08:54
@kittisakLS kittisakLS self-assigned this Nov 7, 2023
Copy link
Contributor

@ravut8 ravut8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have made a few minor revisions to the description of your PR.

@ravut8 ravut8 merged commit a29cc55 into logicspark:main Nov 7, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[refactor]: Change the ComponentProfile "total" property to "usage" based on the "usageLocations" length
2 participants