Add docker builder option to provider #987
Conversation
|
@pascalbreuninger can you have a look to this one and give me some feedback please? |
There was a problem hiding this comment.
@aacebedo thanks for the PR! Got a couple of comments and want to make sure tests are still working
Thanks for the review! Yes I will solve the e2e tests. |
aacebedo
force-pushed
the
aacebedo/add_docker_builder_option
branch
3 times, most recently
from
ec49f97
to
7a60471
Compare
@pascalbreuninger I have fixed the test. I have added a workflow dispatch event to E2E test to ease the next PRs. Don't know if it is ok for you but it helped me a lot as I do not have the same environment as the CI. |
pkg/docker/helper.go
Outdated
| ) | ||
|
|
||
| func (db DockerBuilder) String() string { | ||
| return [...]string{"buildkit", "buildx", ""}[db] |
There was a problem hiding this comment.
last small issue: since the default is now "", the order should probably be updated as well
| return [...]string{"buildkit", "buildx", ""}[db] | |
| return [...]string{"", "buildx", "buildkit"}[db] |
One small cleanup remaining and we're good to merge. |
aacebedo
force-pushed
the
aacebedo/add_docker_builder_option
branch
from
7a60471
to
6389e94
Compare
This PR solves #984 by first checking if podman is used when buildxExists is called and return true in this case.
It also adds a DOCKER_BUILDER option to the provider in order to choose easily between the 2 builders.