Implement waitFor in .devcontainer.json #1342
Open
+57
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the reference implementation I have implemented the
waitFor
enum defined by devcontainer.json, alongside the--skip-non-blocking-commands
flag. The waitFor attribute actually does nothing without this flag, when combined, it allows a developer to skip life cycle hooks. I have tested locally by using devpod and devcontainer cli to run a .devcontainer.In the example here, you can see that all hooks are ran. If I then specify
--skip-non-blocking-commands
, only up to updateContentCommand is ran since this is what I set waitFor to..devcontainer.json
Fixes #162