Implemement .devpodignore #1337
Conversation
| } | ||
| // Remove files from workspace content folder | ||
| for _, exclude := range excludes { | ||
| os.RemoveAll(filepath.Join(workspaceDir, exclude)) |
There was a problem hiding this comment.
I'm not sure if this is expected. We're using a bind mount for the devcontainer with local docker and this would delete the excludes on the users machine
There was a problem hiding this comment.
True, but only from the content folder, i.e. ~/.devpod/context/..., which I think is fine? since other devpod functionality could use this so deleting would help "ignore" the files elsewhere
There was a problem hiding this comment.
True, but only from the content folder, i.e. ~/.devpod/context/...
Yep, we still need to make an exception for local docker and local folder because there it's a direct bind mount to the origin folder
There was a problem hiding this comment.
ah yes your right, my PR description was wrong I had not tested local dir and local docker. Only local dir with kubernetes, which uses the stream RPCs. The deletion here only happens with a git source (since it's in CloneRepositoryForWorkspace). I'm not sure how we can support .devpodignore for the local docker and local dir use case. Unless I symlinked or moved the original folder elsewhere, there will be no way around the bind mount mounting ignored files. But maybe this is fine? Since if you are using local docker and dir, you proboably want everything mounted? What do you think? Can you see a way of supporting?
This PR implements the logic to support
.devpodignorefile. It has been tested using the docker and kubernetes provider with a local and git workspace source. I managed to exclude a test file from a repo with .devpodignoreFixes #1299