Skip to content

Commit

Permalink
Merge pull request #838 from FabianKramm/main
Browse files Browse the repository at this point in the history
fix: inject credentials if proxy command
  • Loading branch information
FabianKramm authored Dec 11, 2023
2 parents b424d85 + 8abf2bc commit 4e03e0f
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions pkg/client/clientimplementation/workspace_client.go
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,12 @@ func (s *workspaceClient) agentInfo(cliOptions provider.CLIOptions) (string, *pr
Options: s.devPodConfig.ProviderOptions(s.Provider()),
}

// if we are running proxy mode
if cliOptions.Proxy {
agentInfo.Agent.InjectGitCredentials = "true"
agentInfo.Agent.InjectDockerCredentials = "true"
}

// we don't send any provider options if proxy because these could contain
// sensitive information and we don't want to allow privileged containers that
// have access to the host to save these.
Expand Down

0 comments on commit 4e03e0f

Please sign in to comment.