Fix strftime implementations for format strings "%F" and "%j" #475
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.) "%F" is supposed to be same as "%Y-%m-%d" (https://www.php.net/manual/en/function.strftime.php) but was "%y-…"
2.) "%j" (day of the year) was wrong in locales with DST shifts because the interval between the start of a day during DST and the start of the year might be less than a multiple of 24 hours (the day when DST starts has just 23 hours and the day when it ends has 25 hours). Compensate by talking the timezone offsets into calculation. The test changes
process.env.TZ
temporarily.Checklist
Yes,
the same update/change?
Contributing and e.g. bundled a test in the
function header comments that fails before this PR, but passes after.