Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue where empty WebUI property is not parsed correctly #3012

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix issue where empty WebUI property is not parsed correctly #3012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion locust/web.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ def swarm() -> Response:
if isinstance(parsed_options_value, bool):
parsed_options_dict[key] = value == "true"
elif parsed_options_value is None:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can do:

elif parsed_options_value is None and value is None:
  parsed_options_dict[key] = None

This way we still get the type casting from the else statement

parsed_options_dict[key] = parsed_options_value
parsed_options_dict[key] = value or None
else:
parsed_options_dict[key] = type(parsed_options_dict[key])(value)

Expand Down
Loading