Fix compute_loss signature compatibility with transformers >= 4.46#155
Closed
ma-kjh wants to merge 11 commits intolocuslab:mainfrom
Closed
Fix compute_loss signature compatibility with transformers >= 4.46#155ma-kjh wants to merge 11 commits intolocuslab:mainfrom
ma-kjh wants to merge 11 commits intolocuslab:mainfrom
Conversation
Added support for additional keyword arguments in compute_loss method.
|
I'm also going to need more recent transformers, so I'm wondering why did you close this PR? Was there something wrong with this fix? |
This was referenced Jan 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Problem
The latest version of
transformers(v4.46+) passes a new argumentnum_items_in_batchto thecompute_lossmethod.Currently, the custom trainers (
GradAscent, etc.) do not accept arbitrary keyword arguments, causing aTypeErrorwhen running with recenttransformersversions.Error log:
TypeError: GradAscent.compute_loss() got an unexpected keyword argument 'num_items_in_batch'Solution
Added
**kwargsto thecompute_lossmethod signature in custom trainers to ensure compatibility with the latesttransformerslibrary.Fixes # (issue)
N/A
Before submitting