Skip to content

fix(website): fix sequence details page of multi-pathogen revocation entries#5626

Merged
fengelniederhammer merged 3 commits intomainfrom
5619-missing-genotype-of-revocation-entries-cant-display-sequence-details
Dec 9, 2025
Merged

fix(website): fix sequence details page of multi-pathogen revocation entries#5626
fengelniederhammer merged 3 commits intomainfrom
5619-missing-genotype-of-revocation-entries-cant-display-sequence-details

Conversation

@fengelniederhammer
Copy link
Copy Markdown
Contributor

@fengelniederhammer fengelniederhammer commented Dec 4, 2025

resolves #5619

Screenshot

PR Checklist

- [ ] All necessary documentation has been adapted.

image image

🚀 Preview: https://5619-missing-genotype-of.loculus.org

@fengelniederhammer fengelniederhammer added the preview Triggers a deployment to argocd label Dec 4, 2025
@chatgpt-codex-connector
Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes the sequence details page for multi-pathogen revocation entries by allowing the suborganism field to be null. Previously, revocation entries with null suborganism values would cause errors, but now the code properly handles this case throughout the application.

Key Changes:

  • Modified type signatures to allow suborganism to be null | Suborganism instead of just Suborganism
  • Updated validation logic to accept null values for the suborganism field
  • Added null checks before accessing suborganism-dependent data

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
website/src/types/detailsJson.ts Updated schema to allow nullable suborganism field
website/src/utils/getSuborganismSegmentAndGeneInfo.tsx Removed function overload signatures (implementation already handled null)
website/src/pages/seq/[accessionVersion]/getSequenceDetailsTableData.ts Updated TableData type to allow null suborganism
website/src/components/SequenceDetailsPage/getTableData.ts Updated return types, validation logic, and error messages to handle null suborganism
website/src/components/SequenceDetailsPage/getTableData.spec.ts Added test case and updated error message expectation for null suborganism handling
website/src/components/SequenceDetailsPage/SequencesDisplay/SequencesContainer.tsx Added null check to return early when suborganism is null
website/src/components/SequenceDetailsPage/SequenceDataUI.tsx Updated Props interface to allow null suborganism
website/src/components/SequenceDetailsPage/RevocationEntryDataTable.astro Updated Props interface to allow null suborganism
website/src/components/SequenceDetailsPage/DataTable.tsx Added null checks before accessing suborganism-dependent reference data

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@corneliusroemer corneliusroemer force-pushed the 5619-missing-genotype-of-revocation-entries-cant-display-sequence-details branch from 40fe433 to dac97e2 Compare December 5, 2025 10:59
@corneliusroemer
Copy link
Copy Markdown
Contributor

I rebased to effectively cherry-pick the changes

Base automatically changed from edit-page-anya to main December 5, 2025 13:44
@anna-parker anna-parker linked an issue Dec 5, 2025 that may be closed by this pull request
@fengelniederhammer fengelniederhammer force-pushed the 5619-missing-genotype-of-revocation-entries-cant-display-sequence-details branch from dac97e2 to dbea671 Compare December 8, 2025 07:29
@fengelniederhammer fengelniederhammer force-pushed the 5619-missing-genotype-of-revocation-entries-cant-display-sequence-details branch from 3a58a50 to 4cc2c6d Compare December 8, 2025 07:46
Copy link
Copy Markdown
Contributor

@anna-parker anna-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - it might make sense to see if we can get rid of the empty nucleotide mutations list for revocation previews still (but we can make a follow up issue for this)

@fengelniederhammer
Copy link
Copy Markdown
Contributor Author

if we can get rid of the empty nucleotide mutations list for revocation previews still (but we can make a follow up issue for this)

AFAICS this is also the case on main for other organisms, i.e. accepted existing behavior. Feel free to open an issue, I won't change it in this PR.

@fengelniederhammer fengelniederhammer merged commit b07a89a into main Dec 9, 2025
42 checks passed
@fengelniederhammer fengelniederhammer deleted the 5619-missing-genotype-of-revocation-entries-cant-display-sequence-details branch December 9, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview Triggers a deployment to argocd

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EVs: add integration tests for full submission process Missing genotype of revocation entries: Can't display sequence details

4 participants