Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spark 3.4 #611

Merged
merged 18 commits into from
Oct 4, 2023
Merged

Spark 3.4 #611

merged 18 commits into from
Oct 4, 2023

Conversation

thomas-maschler
Copy link
Contributor

@thomas-maschler thomas-maschler commented Jun 2, 2023

Add support for Spark 3.2.4, 3.3.2 and 3.4.0

@pomadchin
Copy link
Member

I'll also publish locationtech/geotrellis#3513 once CQs are cleared!

@thomas-maschler
Copy link
Contributor Author

@pomadchin Rasterframes is still on geotrellis 3.6.3. There were some dependency conflicts which prevented us from updating. I will see if it builds with the latest release

@pomadchin
Copy link
Member

@thomas-maschler oh, I guess it's stac4s?

@thomas-maschler
Copy link
Contributor Author

yes, I get

[error] 	* org.typelevel:cats-effect_2.12:3.4.8 (early-semver) is selected over {3.4.6, 2.5.4}
[error] 	    +- org.locationtech.geotrellis:geotrellis-store_2.12:3.7.0 (depends on 3.4.8)
[error] 	    +- com.softwaremill.sttp.client3:catsce2_2.12:3.7.0   (depends on 2.5.4)
[error] 	    +- co.fs2:fs2-core_2.12:3.6.1                         (depends on 3.4.6)
[error]
[error] 	* co.fs2:fs2-core_2.12:3.6.1 (early-semver) is selected over 2.5.11
[error] 	    +- co.fs2:fs2-io_2.12:3.6.1                           (depends on 3.6.1)
[error] 	    +- org.locationtech.geotrellis:geotrellis-store_2.12:3.7.0 (depends on 3.6.1)
[error] 	    +- com.azavea.stac4s:client_2.12:0.8.1                (depends on 2.5.11)

Comment on lines +47 to +49
s"$name-assembly-$sparkVer.jar"
else
s"$name-assembly-$sparkVer-$ver.jar"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I even need to bother about the spark version in the assembly Jar name?

env:
SPARK_VERSION: ${{ matrix.spark_version }}
run:
ulimit -c unlimited
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pomadchin, without this, test suite started to crash for Spark versions <3.4 after I added frameless 0.14.1. Any idea why?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that's a good observation though

@thomas-maschler
Copy link
Contributor Author

@echeipesh, the publishing CI workflow is still incomplete and only builds jar and wheel on the worker but does not publish the files to Maven or Pypi. Do you want to keep this manual for now?

@thomas-maschler thomas-maschler marked this pull request as ready for review June 3, 2023 01:52
@pomadchin
Copy link
Member

pomadchin commented Jun 21, 2023

@thomas-maschler stac4s migrated into the stac org! https://github.com/stac-utils/stac4s

I'll update it once I have some time (:

@pomadchin
Copy link
Member

🔥

@pomadchin
Copy link
Member

Let's merge it as is for now!

@pomadchin pomadchin merged commit 44f9bb4 into locationtech:develop Oct 4, 2023
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants