Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed the issue that the generated vrt.xml is empty when writing out cog #3545

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Fixed the issue that the generated vrt.xml is empty when writing out cog #3545

merged 1 commit into from
Jul 9, 2024

Conversation

dingsl-giser
Copy link
Contributor

@dingsl-giser dingsl-giser commented Jul 9, 2024 •
edited
Loading

Add writer.flush() when writing xml to vrt, fix the problem of writing empty vrt.xml when writing out cog.

@dingsl-giser
Copy link
Contributor Author

@pomadchin I resubmitted the PR, hoping it can be merged.

@pomadchin pomadchin added the bug label Jul 9, 2024
pomadchin
pomadchin approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@pomadchin pomadchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pomadchin pomadchin merged commit 45afefd into locationtech:master Jul 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pomadchin pomadchin pomadchin approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dingsl-giser @pomadchin