Introduce a TextTransformer to replace strings with special chars #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dominikschubert
approved these changes
Jan 21, 2025
tests/test_transformer.py
Outdated
|
|
||
| expected = {"key": "some <value> with more text"} | ||
|
|
||
| # Matching this against a regex does not work, because the + is a special character |
There was a problem hiding this comment.
nit: that comment seems like it was referring to an earlier version of the test code here before the parametrization was introduced?
There was a problem hiding this comment.
That was more a generic comment to explain why we're using the TextTransformer in the first place. I've moved this to the TransformerUtility.text, so all users should now see this explanation:
Creates a new TextTransformer. All occurrences in the string-converted dict will be replaced.
Useful if the text contains special characters that would confuse the RegexTransformer, like '+' or '('.
| @@ -211,6 +211,32 @@ def test_nested_sorting_transformer(self): | |||
| output = transformer.transform(input, ctx=ctx) | |||
| assert output == expected | |||
|
|
|||
| @pytest.mark.parametrize( | |||
| :param text: the text that should be replaced | ||
| :param replacement: the value which will replace the original value. | ||
|
|
||
| :return: RegexTransformer |
There was a problem hiding this comment.
Suggested change
| :return: RegexTransformer | |
| :return: TextTransformer |
There was a problem hiding this comment.
Fixed - good catch!
bblommers
force-pushed
the
text-transformer
branch
from
2c93b18 to
87ff322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The regex transformer works in 99% of the cases, but I ran into some problems when trying to match a base64 representation like
asdf+qwer=.The regex transformer assumes the
+is a special character, so it will not match the exact value. Hence the `TextTransformer, that just transforms the entire string as-is.