Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.4.10 release #201

Merged
merged 1 commit into from
Oct 1, 2024
Merged

2.4.10 release #201

merged 1 commit into from
Oct 1, 2024
+86 −60

Conversation

finnlewis
Copy link
Member

  • Remove accordion icon added by JS and add to twig instead

@AWearring
Remove accordion icon added by JS and add to twig instead (#200)
ba3be61 
* Remove accordion icon added by JS and add to twig instead

* Moved button from JS to Twig

* Removed un-needed commented code

* Removed more commented code

* Updated button to hidden in twig and un-hidden by JS and updated destroy()

* Corrected button selector code

* Removed unrequired class from button

* Hide the button in CSS when it has attribute "hidden"

* Added default heading text, hide in JS

* If heading or buttons don't exist
@finnlewis finnlewis merged commit 8e9ef1c into release-2.x Oct 1, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@finnlewis @AWearring