-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature fix base path #7136
base: main
Are you sure you want to change the base?
Feature fix base path #7136
Conversation
Someone is attempting to deploy a commit to the LobeChat Desktop Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for raising your pull request and contributing to our Community |
TestGru AssignmentSummary
Tip You can |
@dragonzhao93 不好意思,这个 PR 在我看来算不上轻量化的变更,因为涉及到了所有需要做路径跳转或者请求的 URL ,这意味着未来任何一个新增的特性或者页面都要添加这样的前缀,这会大大增加我们的项目维护成本,这不是我期望看到的。这也是为什么我们 V2 准备完全废弃 basePath 的原因。 我期待的轻量化变更是在类似 Middleware 那样的维度通过一个很轻巧的实现来做到 basePath 的重写,如果是这样的解决方案我会考虑合并。 最后,还是非常感谢你的尝试~ 期待能看到更加理想的解决方案! |
@dragonzhao93 Sorry, this PR is not a lightweight change in my opinion, because it involves all URLs that need to be redirected or requested. This means that any new feature or page in the future will have to be added with such a prefix, which will greatly increase the maintenance cost of our project, which is not what I expect to see. This is also why we V2 is preparing to completely abandon basePath. The lightweight change I'm looking forward to is to achieve basePath rewrite through a very light implementation in a dimension like Middleware. If this is the solution I would consider merging. In addition, thank you very much for your attempt~ I look forward to a more ideal solution~ |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
适配NEXT_PUBLIC_BASE_PATH
📝 补充信息 | Additional Information