feat: handle hodl invoices asynchronously tasks.py #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
santyr
commented
Jul 16, 2024
santyr
commented
- Modified the on_invoice_paid function to call pay_invoice asynchronously using asyncio.create_task.
- Added a new function pay_invoice_in_background to handle the asynchronous payment processing and exception handling.
- Ensured that the main event loop remains responsive even when encountering hodl invoices by running pay_invoice in the background.
dni
approved these changes
Nov 29, 2024
|
i think hold invoices could also be handled more generel inside the pay_invoice service. what do you think @motorina0 |
talvasconcelos
approved these changes
Nov 29, 2024
|
CI fails for |
- Modified the on_invoice_paid function to call pay_invoice asynchronously using asyncio.create_task. - Added a new function pay_invoice_in_background to handle the asynchronous payment processing and exception handling. - Ensured that the main event loop remains responsive even when encountering hodl invoices by running pay_invoice in the background.
dni
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.