Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow insecure http for advanced users #74

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

oren-z0
Copy link

@oren-z0 oren-z0 commented Dec 9, 2024

I've forked v0.5.6 (My Umbrel can't run v1.0.0) and added a checkbox to allow insecure http (instead of https).
This is useful for advanced home-node operators that open their LNBits to the web in complicated routing schemes, i.e. ngrok or Holesail. In these cases the routed request might not be an https request.

Obviously if the operator access LNBits from a different domain than the his final users (i.e. localhost) he should be aware that the lnurls and lightning-addresses encode the wrong domain. Again, this is for advanced operators.

Feel free to test by adding https://raw.githubusercontent.com/oren-z0/lnurlp/allow-insecure-http/manifest.json to your Extension Sources.

@prusnak
Copy link
Collaborator

prusnak commented Dec 11, 2024

that open their LNBits to the web in complicated routing schemes, i.e. ngrok or Holesail.

If you use complicated routing schemes, how hard is to add HTTPS into the mix?

I feel the use case you mention is quite dubious and without further understanding what are you trying to achieve I think it is not worth complicating the code.

@oren-z0
Copy link
Author

oren-z0 commented Dec 11, 2024

@prusnak Yes, it's pretty hard to add HTTPS.
It's easy to setup a VPS with some free subdomain using a cloud service (in my case using glitch.com), but then the https request is converted to an http request. Same for cloud-functions. VPS routing is especially important to home users that run an Umbrel machine in a local network (NAT).

It would also be nice to support headers like X-Forwarded-Host for these cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants