Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TorchToLinalg] Fix AtenReflectionPad2dOp lowering to not assert when dimensions unknown #3758

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

[TorchToLinalg] Fix AtenReflectionPad2dOp lowering to not assert when dimensions unknown #3758

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
4b17fb5
Fix AtenReflectionPad2dOp conversion to not assert when dimensions un…
giacs-epic Oct 3, 2024
712f6e3
Use correct constant for dynamic dim
giacs-epic Oct 3, 2024
5c0cf81
Merge branch 'main' into fix_reflection_pad2d_unknown_size_crash
giacs-epic Nov 15, 2024
a2973b0
Add ReflectionPad2d dynamic test
giacs-epic Nov 15, 2024
e2b26e5
Add dynamic pad asserts
giacs-epic Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 12 additions & 8 deletions lib/Conversion/TorchToLinalg/DataMovement.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,14 +404,18 @@ class ConvertAtenReflectionPad2dOp
Value hDimSize = inputShape[hDim];
Value vDimSize = inputShape[vDim];

assert(getHPadArgument(LEFT) < inputType.getShape()[hDim] &&
"Left padding too large");
assert(getHPadArgument(RIGHT) < inputType.getShape()[hDim] &&
"Right padding too large");
assert(getVPadArgument(TOP) < inputType.getShape()[vDim] &&
"Top padding too large");
assert(getVPadArgument(BOTTOM) < inputType.getShape()[vDim] &&
"Bottom padding too large");
if (inputType.getShape()[hDim] != ShapedType::kDynamic) {
assert(getHPadArgument(LEFT) < inputType.getShape()[hDim] &&
"Left padding too large");
assert(getHPadArgument(RIGHT) < inputType.getShape()[hDim] &&
"Right padding too large");
}
if (inputType.getShape()[vDim] != ShapedType::kDynamic) {
assert(getVPadArgument(TOP) < inputType.getShape()[vDim] &&
"Top padding too large");
assert(getVPadArgument(BOTTOM) < inputType.getShape()[vDim] &&
"Bottom padding too large");
}

Type indexType = rewriter.getIndexType();
Value zero = getConstant(rewriter, loc, 0, indexType);
Expand Down
Loading