Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ONNX] Fix resize ceil numerics and add half_pixel_symmetric support #3443

Merged
merged 3 commits into from
Jun 12, 2024
Merged

[ONNX] Fix resize ceil numerics and add half_pixel_symmetric support #3443

merged 3 commits into from
Jun 12, 2024

Conversation

zjgarvey
Copy link
Collaborator

This patch fixes several failing tests in our external test suite, and addresses some of the issues discussed in #3420

@zjgarvey zjgarvey mentioned this pull request Jun 10, 2024
Closed
@mgehre-amd
Copy link
Contributor

This patch fixes several failing tests in our external test suite, and addresses some of the issues discussed in #3420

Curious, I found https://github.com/nod-ai/e2eshark-reports/blob/main/2024-06-10/onnx_reports/statusreport.md but I cannot find a corresponding report for that external test suite (essentially per op). Is that available?

@zjgarvey
Copy link
Collaborator Author

zjgarvey commented Jun 10, 2024 •
edited
Loading

I was testing in a local build of iree with this torch-mlir commit. IREE's ci runs the onnx node tests, so when we bump torch-mlir there, we should get a few more passes. Here is an example of an IREE Regression Test

@zjgarvey
Copy link
Collaborator Author

This patch fixes several failing tests in our external test suite, and addresses some of the issues discussed in #3420

Curious, I found https://github.com/nod-ai/e2eshark-reports/blob/main/2024-06-10/onnx_reports/statusreport.md but I cannot find a corresponding report for that external test suite (essentially per op). Is that available?

I forgot to quote the reply, sorry about that. In any case, I merged the work you committed earlier today, @mgehre-amd. Would you mind reviewing this PR?

@zjgarvey zjgarvey requested a review from mgehre-amd June 10, 2024 20:40
@zjgarvey
Copy link
Collaborator Author

There is also a tracking issue for ONNX Frontend Support that you can check out if you want to contribute towards this project.

mgehre-amd
mgehre-amd approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@mgehre-amd mgehre-amd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! The implementation looks correct. Can you please add a test for it?

mgehre-amd

This comment was marked as duplicate.

Sign in to view

@zjgarvey zjgarvey merged commit 7cd3368 into llvm:main Jun 12, 2024
3 checks passed
mgehre-amd pushed a commit to Xilinx/torch-mlir that referenced this pull request Jun 12, 2024
@zjgarvey @mgehre-amd
[ONNX] Fix resize ceil numerics and add half_pixel_symmetric support (l…
27e8eb2 
…lvm#3443)

This patch fixes several failing tests in our [external test
suite](https://github.com/nod-ai/SHARK-TestSuite/tree/main/iree_tests/onnx/node/generated),
and addresses some of the issues discussed in llvm#3420
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgehre-amd mgehre-amd mgehre-amd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zjgarvey @mgehre-amd