[lit] Drop shell feature from all upstream projects

[boomanaiden154]

Now that no tests actually use the shell feature to conditionally run, drop the feature altogether to prevent backslide.

[llvmbot]

@llvm/pr-subscribers-testing-tools

Author: Aiden Grossman (boomanaiden154)

Changes

Now that no tests actually use the shell feature to conditionally run, drop the feature altogether to prevent backslide.

---

Full diff: https://github.com/llvm/llvm-project/pull/173341.diff

2 Files Affected:

• (modified) compiler-rt/test/lit.common.cfg.py (-2)
• (modified) llvm/utils/lit/lit/llvm/config.py (-3)

diff --git a/compiler-rt/test/lit.common.cfg.py b/compiler-rt/test/lit.common.cfg.py
index 19daa6bbec229..fa74408383638 100644
--- a/compiler-rt/test/lit.common.cfg.py
+++ b/compiler-rt/test/lit.common.cfg.py
@@ -126,8 +126,6 @@ def push_dynamic_library_lookup_path(config, new_path):
 
 # Setup test format.
 config.test_format = lit.formats.ShTest(execute_external)
-if execute_external:
-    config.available_features.add("shell")
 
 target_is_msvc = bool(re.match(r".*-windows-msvc$", config.target_triple))
 target_is_windows = bool(re.match(r".*-windows.*$", config.target_triple))
diff --git a/llvm/utils/lit/lit/llvm/config.py b/llvm/utils/lit/lit/llvm/config.py
index 28a7ab25a0c3b..8b794c6978890 100644
--- a/llvm/utils/lit/lit/llvm/config.py
+++ b/llvm/utils/lit/lit/llvm/config.py
@@ -79,9 +79,6 @@ def __init__(self, lit_config, config):
             if not self.use_lit_shell and lit_config.update_tests:
                 print("note: --update-tests is not supported when using external shell")
 
-        if not self.use_lit_shell:
-            features.add("shell")
-
         self.with_system_environment(
             [
                 "ASAN_SYMBOLIZER_PATH",

[boomanaiden154]

This should be good for review, but needs a couple prereq PRs to land before:

1. [flang] Remove REQUIRES: shell lines form tests #173339
2. [compiler-rt] Remove REQUIRES: shell lines #173338
3. [Clang] Remove remaining REQUIRES: shell statements #173335