Skip to content

[MLIR][NFC] Fixed some Typos #144263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdulraheembeigh
Copy link
Contributor

-- Fixed some typos in Operation.h

Signed-off: Abdul Raheem Beigh [email protected]

-- Fixed a typo in Operation.h

Signed-off: Abdul Raheem Beigh [email protected]
@llvmbot llvmbot added mlir:core MLIR Core Infrastructure mlir labels Jun 15, 2025
@llvmbot
Copy link
Member

llvmbot commented Jun 15, 2025

@llvm/pr-subscribers-mlir

@llvm/pr-subscribers-mlir-core

Author: Abdul Raheem (abdulraheembeigh)

Changes

-- Fixed some typos in Operation.h

Signed-off: Abdul Raheem Beigh [email protected]


Full diff: https://github.com/llvm/llvm-project/pull/144263.diff

1 Files Affected:

  • (modified) mlir/include/mlir/IR/Operation.h (+9-9)
diff --git a/mlir/include/mlir/IR/Operation.h b/mlir/include/mlir/IR/Operation.h
index 68ab1527b480a..1c2c04e718bf7 100644
--- a/mlir/include/mlir/IR/Operation.h
+++ b/mlir/include/mlir/IR/Operation.h
@@ -30,7 +30,7 @@ enum class OpProperties : char {};
 
 /// Operation is the basic unit of execution within MLIR.
 ///
-/// The following documentation are recommended to understand this class:
+/// The following documentations are recommended to understand this class:
 /// - https://mlir.llvm.org/docs/LangRef/#operations
 /// - https://mlir.llvm.org/docs/Tutorials/UnderstandingTheIRStructure/
 ///
@@ -66,14 +66,14 @@ enum class OpProperties : char {};
 /// tail allocated with the operation class itself, but can be dynamically moved
 /// out-of-line in a dynamic allocation as needed.
 ///
-/// An Operation may contain optionally one or multiple Regions, stored in a
+/// An Operation may optionally contain one or multiple Regions, stored in a
 /// tail allocated array. Each `Region` is a list of Blocks. Each `Block` is
 /// itself a list of Operations. This structure is effectively forming a tree.
 ///
 /// Some operations like branches also refer to other Block, in which case they
 /// would have an array of `BlockOperand`.
 ///
-/// An Operation may contain optionally a "Properties" object: this is a
+/// An Operation may optionally contain a "Properties" object: this is a
 /// pre-defined C++ object with a fixed size. This object is owned by the
 /// operation and deleted with the operation. It can be converted to an
 /// Attribute on demand, or loaded from an Attribute.
@@ -286,7 +286,7 @@ class alignas(8) Operation final
   void destroy();
 
   /// This drops all operand uses from this operation, which is an essential
-  /// step in breaking cyclic dependences between references when they are to
+  /// step in breaking cyclic dependencies between references when they are to
   /// be deleted.
   void dropAllReferences();
 
@@ -448,11 +448,11 @@ class alignas(8) Operation final
   /// to use Properties instead.
   void setInherentAttr(StringAttr name, Attribute value);
 
-  /// Access a discardable attribute by name, returns an null Attribute if the
+  /// Access a discardable attribute by name, returns a null Attribute if the
   /// discardable attribute does not exist.
   Attribute getDiscardableAttr(StringRef name) { return attrs.get(name); }
 
-  /// Access a discardable attribute by name, returns an null Attribute if the
+  /// Access a discardable attribute by name, returns a null Attribute if the
   /// discardable attribute does not exist.
   Attribute getDiscardableAttr(StringAttr name) { return attrs.get(name); }
 
@@ -515,7 +515,7 @@ class alignas(8) Operation final
   DictionaryAttr getAttrDictionary();
 
   /// Set the attributes from a dictionary on this operation.
-  /// These methods are expensive: if the dictionnary only contains discardable
+  /// These methods are expensive: if the dictionary only contains discardable
   /// attributes, `setDiscardableAttrs` is more efficient.
   void setAttrs(DictionaryAttr newAttrs);
   void setAttrs(ArrayRef<NamedAttribute> newAttrs);
@@ -529,7 +529,7 @@ class alignas(8) Operation final
   }
 
   /// Return the specified attribute if present, null otherwise.
-  /// These methods are expensive: if the dictionnary only contains discardable
+  /// These methods are expensive: if the dictionary only contains discardable
   /// attributes, `getDiscardableAttr` is more efficient.
   Attribute getAttr(StringAttr name) {
     if (getPropertiesStorageSize()) {
@@ -950,7 +950,7 @@ class alignas(8) Operation final
   /// operation.
   static constexpr unsigned kOrderStride = 5;
 
-  /// Update the order index of this operation of this operation if necessary,
+  /// Update the order index of this operation if necessary,
   /// potentially recomputing the order of the parent block.
   void updateOrderIfNecessary();
 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mlir:core MLIR Core Infrastructure mlir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants