Skip to content

[Clang][OpenMP][LoopTransformations] Fix incorrect number of generated loops for Tile and Reverse directives #140532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 18, 2025

Conversation

eZWALT
Copy link
Contributor

@eZWALT eZWALT commented May 19, 2025

This patch is closely related to #139293 and addresses an existing issue in the loop transformation codebase. Specifically, it corrects the handling of the NumGeneratedLoops variable in OMPLoopTransformationDirective AST nodes and its inheritors (such as OMPUnrollDirective, OMPTileDirective, etc.).

Previously, this variable was inaccurately set for certain transformations like reverse or tile. While this did not lead to functional bugs, since the value was only checked to determine whether it was greater than zero or equal to zero, the inconsistency could introduce problems when supporting more complex directives in the future.

@alexey-bataev , @Meinersbur

Copy link

Thank you for submitting a Pull Request (PR) to the LLVM Project!

This PR will be automatically labeled and the relevant teams will be notified.

If you wish to, you can add reviewers by using the "Reviewers" section on this page.

If this is not working for you, it is probably because you do not have write permissions for the repository. In which case you can instead tag reviewers by name in a comment by using @ followed by their GitHub username.

If you have received no comments on your PR for a week, you can request a review by "ping"ing the PR by adding a comment “Ping”. The common courtesy "ping" rate is once a week. Please remember that you are asking for valuable time from other developers.

If you have further questions, they may be answered by the LLVM GitHub User Guide.

You can also ask questions in a comment on this PR, on the LLVM Discord or on the forums.

@llvmbot llvmbot added clang Clang issues not falling into any other category clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:openmp OpenMP related changes to Clang labels May 19, 2025
@llvmbot
Copy link
Member

llvmbot commented May 19, 2025

@llvm/pr-subscribers-clang-modules

@llvm/pr-subscribers-clang

Author: Walter J.T.V (eZWALT)

Changes

This patch is closely related to #139293 and addresses an existing issue in the loop transformation codebase. Specifically, it corrects the handling of the NumGeneratedLoops variable in OMPLoopTransformationDirective AST nodes and its inheritors (such as OMPUnrollDirective, OMPTileDirective, etc.).

Previously, this variable was inaccurately set for certain transformations like reverse or tile. While this did not lead to functional bugs, since the value was only checked to determine whether it was greater than zero or equal to zero, the inconsistency could introduce problems when supporting more complex directives in the future.


Full diff: https://github.com/llvm/llvm-project/pull/140532.diff

1 Files Affected:

  • (modified) clang/include/clang/AST/StmtOpenMP.h (+4-2)
diff --git a/clang/include/clang/AST/StmtOpenMP.h b/clang/include/clang/AST/StmtOpenMP.h
index 736bcabbad1f7..7ded194dd6eb2 100644
--- a/clang/include/clang/AST/StmtOpenMP.h
+++ b/clang/include/clang/AST/StmtOpenMP.h
@@ -5790,7 +5790,9 @@ class OMPReverseDirective final : public OMPLoopTransformationDirective {
   explicit OMPReverseDirective(SourceLocation StartLoc, SourceLocation EndLoc)
       : OMPLoopTransformationDirective(OMPReverseDirectiveClass,
                                        llvm::omp::OMPD_reverse, StartLoc,
-                                       EndLoc, 1) {}
+                                       EndLoc, 1) {
+    setNumGeneratedLoops(1);
+  }
 
   void setPreInits(Stmt *PreInits) {
     Data->getChildren()[PreInitsOffset] = PreInits;
@@ -5857,7 +5859,7 @@ class OMPInterchangeDirective final : public OMPLoopTransformationDirective {
       : OMPLoopTransformationDirective(OMPInterchangeDirectiveClass,
                                        llvm::omp::OMPD_interchange, StartLoc,
                                        EndLoc, NumLoops) {
-    setNumGeneratedLoops(3 * NumLoops);
+    setNumGeneratedLoops(NumLoops);
   }
 
   void setPreInits(Stmt *PreInits) {

@rofirrim rofirrim requested a review from alexey-bataev May 20, 2025 09:18
@alexey-bataev
Copy link
Member

Do we need the number of generated loops at all? Is it used anywhere? Maybe it worth it to remove it?

@eZWALT
Copy link
Contributor Author

eZWALT commented May 20, 2025

@alexey-bataev
It’s true that NumGeneratedLoops is used throughout the existing OpenMP loop transformation infrastructure. While in some cases its usage could potentially be replaced by NumGeneratedLoopNests (especially when only checking for values like 0 or 1), the two variables convey distinct semantic information.

NumGeneratedLoops refers to the number of individual loops produced, while NumGeneratedLoopNests captures the structure of nested loops. For current and future transformations, having access to both could be important for representing complex constructs accurately.

Removing NumGeneratedLoops would require changes across the loop transformations logic it's not clear the benefit would justify that cost, particularly given the potential utility of retaining this semantic distinction.I’m not 100% certain all current transformations depend on that level of detail, but I believe it’s valuable to preserve until proven otherwise.

@eZWALT
Copy link
Contributor Author

eZWALT commented May 21, 2025

@alexey-bataev It’s true that NumGeneratedLoops is used throughout the existing OpenMP loop transformation infrastructure. While in some cases its usage could potentially be replaced by NumGeneratedLoopNests (especially when only checking for values like 0 or 1), the two variables convey distinct semantic information.

NumGeneratedLoops refers to the number of individual loops produced, while NumGeneratedLoopNests captures the structure of nested loops. For current and future transformations, having access to both could be important for representing complex constructs accurately.

Removing NumGeneratedLoops would require changes across the loop transformations logic it's not clear the benefit would justify that cost, particularly given the potential utility of retaining this semantic distinction.I’m not 100% certain all current transformations depend on that level of detail, but I believe it’s valuable to preserve until proven otherwise.

I've identified a case where NumGeneratedLoops is necessary and cannot be replaced by NumGeneratedLoopNests: the permutation clause of the interchange directive, e.g., permutation(2,1,...). In this transformation, we’re not interested in the number of top-level loop nests, but rather in how many individual loops exist within a single top-level nest, and how to reorder them. Let me know if i have clarified your doubts or if you want more examples, sometimes this kind of details are somewhat difficult to explain easily.

@alexey-bataev
Copy link
Member

Are there any tests that might be affected by this change?

@eZWALT
Copy link
Contributor Author

eZWALT commented May 21, 2025

Are there any tests that might be affected by this change?

Yesterday I ran all the tests (check-clang-openmp and check-clang) and no change in the behaviour or incidence was found, although i'll re-execute them just as a sanity check. Just a remainder but this merge request should be merged firstly before #139293.

@alexey-bataev
Copy link
Member

It would be good to try to find the cases that may reveal this issues before committing the patch

@eZWALT
Copy link
Contributor Author

eZWALT commented May 21, 2025

It would be good to try to find the cases that may reveal this issues before committing the patch

Yes, i'll go through loop transformations tests and notify you tomorrow if this is the case, but i'm pretty sure that these are not breaking changes for the same reason that i told you on the other PR, NumGeneratedLoops is almost only being used in the CheckTransformableLoopNest and well i will have to check both ActOnOMPReverse/InterchangeDirective

@eZWALT
Copy link
Contributor Author

eZWALT commented May 21, 2025

Before leaving i can attest that the regression tests have been passed twice 👍

@eZWALT
Copy link
Contributor Author

eZWALT commented May 22, 2025

@alexey-bataev
After conducting an examination of the directive handling logic, I can confidently state that the number of generated loops (NumGeneratedLoops) does not affect the semantic checks for the majority of transformations. This is because values are usually hardcoded in the ActOnXXX semantic handlers. For example:

  • In the case of the 'reverse' directive, the number of loops (NumLoops) is hardcoded to 1, meaning it remains unaffected by any external loop count logic.

  • For the 'interchange' directive, the number of loops is also explicitly set using the following logic:

size_t NumLoops = PermutationClause ? PermutationClause->getNumLoops() : 2;

These values are passed into the checkTransformableLoopNest function and are not accessed elsewhere in the codebase, except:

@alexey-bataev
Copy link
Member

@alexey-bataev After conducting an examination of the directive handling logic, I can confidently state that the number of generated loops (NumGeneratedLoops) does not affect the semantic checks for the majority of transformations. This is because values are usually hardcoded in the ActOnXXX semantic handlers. For example:

  • In the case of the 'reverse' directive, the number of loops (NumLoops) is hardcoded to 1, meaning it remains unaffected by any external loop count logic.
  • For the 'interchange' directive, the number of loops is also explicitly set using the following logic:
size_t NumLoops = PermutationClause ? PermutationClause->getNumLoops() : 2;

These values are passed into the checkTransformableLoopNest function and are not accessed elsewhere in the codebase, except:

Can you remove these hardcoded values and use the stored value instead? Otherwise, it is meaningless and should be removed

@eZWALT
Copy link
Contributor Author

eZWALT commented May 23, 2025

@alexey-bataev After conducting an examination of the directive handling logic, I can confidently state that the number of generated loops (NumGeneratedLoops) does not affect the semantic checks for the majority of transformations. This is because values are usually hardcoded in the ActOnXXX semantic handlers. For example:

  • In the case of the 'reverse' directive, the number of loops (NumLoops) is hardcoded to 1, meaning it remains unaffected by any external loop count logic.
  • For the 'interchange' directive, the number of loops is also explicitly set using the following logic:
size_t NumLoops = PermutationClause ? PermutationClause->getNumLoops() : 2;

These values are passed into the checkTransformableLoopNest function and are not accessed elsewhere in the codebase, except:

Can you remove these hardcoded values and use the stored value instead? Otherwise, it is meaningless and should be removed

But this rigidity stems from the checkTransformableLoopNest, which needs the number of loops to be specified beforehand. Changing this wouldn't make much sense. The NumGeneratedLoops information is only available after the creation of the OMPLoopTransformation AST nodes, but the number of loops must be known before that.

Note that inferring this knowledge is trivial in the old scheme of loop transformations, since almost all have one top-level loop, or the loop count is specified by a clause , for example, PermutationClause. OMPFuseDirective is the only one where the number of loops (both top-level and nested) is dynamic, depending on the user code. Therefore, it is mandatory to do an analysis to gather the shape of the loop sequence. Probably I haven’t explained myself well enough, but I want to stress the difference:

  • NumLoops refers to the loops expected or known beforehand — which, in most directives, can be hardcoded.
  • NumGeneratedLoops is the total number of loops after transformation, stored as semantic information in the AST.
  • NumGeneratedLoopNests is the number of top-level loop nests, which is important for loop sequence transformations like fuse or split.

Preserving this semantic information is important, and there’s no reason to change it right now.

@alexey-bataev
Copy link
Member

What I see in the source code that it is used as a boolean flag. Can we transform it to bool? There is no need to keep it integer

@eZWALT
Copy link
Contributor Author

eZWALT commented May 23, 2025

What I see in the source code that it is used as a boolean flag. Can we transform it to bool? There is no need to keep it integer

Please could you cite the exact line? I'm not sure if you are refering to the logic inside checkTransformableLoopNest or not.

@alexey-bataev
Copy link
Member

What I see in the source code that it is used as a boolean flag. Can we transform it to bool? There is no need to keep it integer

Please could you cite the exact line? I'm not sure if you are refering to the logic inside checkTransformableLoopNest or not.

I check getNumGeneratedLoops() function usage. I see that it is used only in 2 linesб which can be replaced by just a boolean

@eZWALT
Copy link
Contributor Author

eZWALT commented May 23, 2025

What I see in the source code that it is used as a boolean flag. Can we transform it to bool? There is no need to keep it integer

Please could you cite the exact line? I'm not sure if you are refering to the logic inside checkTransformableLoopNest or not.

I check getNumGeneratedLoops() function usage. I see that it is used only in 2 linesб which can be replaced by just a boolean

We could add a boolean function like 'AreThereGeneratedLoops()', but getGeneratedNumLoops() is also used to count the total loops inside 'AnalyzeLoopSequence', which feeds into NumGeneratedLoops in OMPFuseDirective. Changing its return type would break that. While we could remove NumGeneratedLoops out of OMPLoopTransformation AST nodes, it provides useful semantic flexibility for future transformations. There’s a tradeoff, but I believe keeping it does more good than harm.

@eZWALT
Copy link
Contributor Author

eZWALT commented May 27, 2025

gentle ping @alexey-bataev

@alexey-bataev
Copy link
Member

AnalyzeLoopSequence

Could you point, where this is located?

@eZWALT
Copy link
Contributor Author

eZWALT commented May 28, 2025

AnalyzeLoopSequence

Could you point, where this is located?

Of course, See line 14315 in SemaOpenMP.cpp

@eZWALT
Copy link
Contributor Author

eZWALT commented May 28, 2025

AnalyzeLoopSequence

Could you point, where this is located?

Although now that i think about it, this function is not inside this PR but rather on the PR #139293, but the dependency is clear.

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 1, 2025

gentle ping :)

@Meinersbur
Copy link
Member

This change makes sense to me. In principle, the information of generated loops is only needed in dependent contexts (not yet fully expanded templates); elsewhere we get the loop nest structure from getTransformedStmt(). The use in doForAllLoops is meant to delay evaluation for when the template is instantiated. A QoI would be able to check the loop structure within a template from this information, even without it needed to be instantiated. I don't think we should remove the information only to be re-added again for #139293.

I think a test case could be possible under the following conditions:

  1. reverse construct (number of generated loops of tile is positive in either case)
  2. In a template definition (dependent context)
  3. Loop bounds of reversed loop depends on template parameter (seeing
    if (SemaRef.CurContext->isDependentContext())
    this might not be necessary)
  4. Another construct applied to the generated loop of the reverse (e.g. unroll)

In that case doForAllLoops should break instead of return causing the following code to execute on the OMPReverseConstruct itself instead of a loop, causing an assertion to fail.

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 4, 2025

I originally kept the NumGeneratedLoops information consistent despite being partially subsumed by NumGeneratedLoopNests (Note that its not actually the same, it returns the number of generated loops in total adding nested loops, but due to the current usage of this semantic information I could argue they serve the same purpose) just in case this information was going to be used for future OpenMP Transformations or semantic logic maybe in OpenMP 7.0. If you both think this information about nested loops will never be used (Maybe if fusion gets a clause for multi-level fusion / fission could become relevant...), then I just remove it, but instead of storing a boolean value, a boolean function hasGeneratedLoops = self->NumGeneratedLoops > 0 could be coded.

After revising this topic thoroughly, I believe the most reasonable course of action would be to close this PR and keep NumGeneratedLoops as it is currently in this patch. Then, swap the semantic information of NumGeneratedLoops <-> NumGeneratedLoopNests and remove NumGeneratedLoopNests in patch #139293 . This would also enable me to remove unnecessary computations that were performed in AnalyzeLoopSequence to keep NumGeneratedLoops consistent, simplifying logic and removing this second variable.

@alexey-bataev , @Meinersbur what do you think? Will this information ever be needed?

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 9, 2025

gentle ping @alexey-bataev @Meinersbur ;)

Copy link
Member

@Meinersbur Meinersbur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am OK with this patch as-is, independented of #139293 since it was cleary a (my) mistake. Just a test case to detect regressions would be nice if possible.

So I LGTM this patch. If @alexey-bataev wants additional changes, this can be done independently.

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 11, 2025

I originally kept the NumGeneratedLoops information consistent despite being partially subsumed by NumGeneratedLoopNests (Note that its not actually the same, it returns the number of generated loops in total adding nested loops, but due to the current usage of this semantic information I could argue they serve the same purpose) just in case this information was going to be used for future OpenMP Transformations or semantic logic maybe in OpenMP 7.0. If you both think this information about nested loops will never be used (Maybe if fusion gets a clause for multi-level fusion / fission could become relevant...), then I just remove it, but instead of storing a boolean value, a boolean function hasGeneratedLoops = self->NumGeneratedLoops > 0 could be coded.

After revising this topic thoroughly, I believe the most reasonable course of action would be to close this PR and keep NumGeneratedLoops as it is currently in this patch. Then, swap the semantic information of NumGeneratedLoops <-> NumGeneratedLoopNests and remove NumGeneratedLoopNests in patch #139293 . This would also enable me to remove unnecessary computations that were performed in AnalyzeLoopSequence to keep NumGeneratedLoops consistent, simplifying logic and removing this second variable.

@alexey-bataev , @Meinersbur what do you think? Will this information ever be needed?

Thank you! But before accepting the merge, does this mean that we discard everything that i said about refactoring these variables and just keep it as it is in both reviews @alexey-bataev ? Also, could you @Meinersbur specify what exactly do you mean with a regression test for such thing? You mean like incorporating some kind of logic which includes NumGeneratedLoops in all LoopTransformation directives or just tile and reverse? Just want to be sure before proceeding with #139293, in the aforementioned case it would not need further revision.

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 16, 2025

I originally kept the NumGeneratedLoops information consistent despite being partially subsumed by NumGeneratedLoopNests (Note that its not actually the same, it returns the number of generated loops in total adding nested loops, but due to the current usage of this semantic information I could argue they serve the same purpose) just in case this information was going to be used for future OpenMP Transformations or semantic logic maybe in OpenMP 7.0. If you both think this information about nested loops will never be used (Maybe if fusion gets a clause for multi-level fusion / fission could become relevant...), then I just remove it, but instead of storing a boolean value, a boolean function hasGeneratedLoops = self->NumGeneratedLoops > 0 could be coded.
After revising this topic thoroughly, I believe the most reasonable course of action would be to close this PR and keep NumGeneratedLoops as it is currently in this patch. Then, swap the semantic information of NumGeneratedLoops <-> NumGeneratedLoopNests and remove NumGeneratedLoopNests in patch #139293 . This would also enable me to remove unnecessary computations that were performed in AnalyzeLoopSequence to keep NumGeneratedLoops consistent, simplifying logic and removing this second variable.
@alexey-bataev , @Meinersbur what do you think? Will this information ever be needed?

Thank you! But before accepting the merge, does this mean that we discard everything that i said about refactoring these variables and just keep it as it is in both reviews @alexey-bataev ? Also, could you @Meinersbur specify what exactly do you mean with a regression test for such thing? You mean like incorporating some kind of logic which includes NumGeneratedLoops in all LoopTransformation directives or just tile and reverse? Just want to be sure before proceeding with #139293, in the aforementioned case it would not need further revision.

I'm guessing that is a yes, could you @alexey-bataev please approve the workflows and we proceed to merge? Then we can go straight into the #139293 PR :)

@rofirrim
Copy link
Collaborator

I'm guessing that is a yes, could you @alexey-bataev please approve the workflows and we proceed to merge? Then we can go straight into the #139293 PR :)

I did that already.

@Meinersbur
Copy link
Member

Meinersbur commented Jun 16, 2025

Thank you! But before accepting the merge, does this mean that we discard everything that i said about refactoring these variables and just keep it as it is in both reviews @alexey-bataev ? Also, could you @Meinersbur specify what exactly do you mean with a regression test for such thing? You mean like incorporating some kind of logic which includes NumGeneratedLoops in all LoopTransformation directives or just tile and reverse? Just want to be sure before proceeding with #139293, in the aforementioned case it would not need further revision.

Whatever the refactoring will be, this I think this patch is useful by itself. Even if the refactoring will delete all this code, the commit can be cherry-picked for those who do not want the refactoring. I don't think we should work forever on obvious fixes in case we can find something nicer.

With the reproducer I meant the setNumGeneratedLoops(1); for the reverse directive. It might make a difference in OMPLoopBasedDirective::doForAllLoop() which might think there are no further loops to iterate into (if (NumGeneratedLoops == 0) {) when in fact there is. This requires multiple nesting of loop transformations within templates which might be difficult to find a reproducer for. Since I think this fix is rather obvious, I would prioritize fixing it over spending a lot of time finding a regression test.

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 17, 2025

Thank you! But before accepting the merge, does this mean that we discard everything that i said about refactoring these variables and just keep it as it is in both reviews @alexey-bataev ? Also, could you @Meinersbur specify what exactly do you mean with a regression test for such thing? You mean like incorporating some kind of logic which includes NumGeneratedLoops in all LoopTransformation directives or just tile and reverse? Just want to be sure before proceeding with #139293, in the aforementioned case it would not need further revision.

Whatever the refactoring will be, this I think this patch is useful by itself. Even if the refactoring will delete all this code, the commit can be cherry-picked for those who do not want the refactoring. I don't think we should work forever on obvious fixes in case we can find something nicer.

With the reproducer I meant the setNumGeneratedLoops(1); for the reverse directive. It might make a difference in OMPLoopBasedDirective::doForAllLoop() which might think there are no further loops to iterate into (if (NumGeneratedLoops == 0) {) when in fact there is. This requires multiple nesting of loop transformations which might be difficult to find a reproducer for. Since I think this fix is rather obvious, I would prioritize fixing it over spending a lot of time finding a regression test.

Okay now I get it, it makes sense! I'll upload the commit right now and check the tests just in case! Could you then tomorrow if the changes seems ok to you merge the pull request? I dont have enough permissions to perform such actions!

@llvmbot llvmbot added the clang:modules C++20 modules and Clang Header Modules label Jun 18, 2025
@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 18, 2025

Gentle ping @Meinersbur, if i understood you correctly, these were the changes you were talking about. I reran the whole test pipeline and everything works fine. Can you accept if this looks ok to you? thanks!

@alexey-bataev
Copy link
Member

Gentle ping @Meinersbur, if i understood you correctly, these were the changes you were talking about. I reran the whole test pipeline and everything works fine. Can you accept if this looks ok to you? thanks!

I think he approved already your changes, you can merge the patch

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 18, 2025

Gentle ping @Meinersbur, if i understood you correctly, these were the changes you were talking about. I reran the whole test pipeline and everything works fine. Can you accept if this looks ok to you? thanks!

I think he approved already your changes, you can merge the patch

Well yes but i don't have enough permissions to merge.

@Meinersbur Meinersbur merged commit 8c3fbaf into llvm:main Jun 18, 2025
3 checks passed
Copy link

@eZWALT Congratulations on having your first Pull Request (PR) merged into the LLVM Project!

Your changes will be combined with recent changes from other authors, then tested by our build bots. If there is a problem with a build, you may receive a report in an email or a comment on this PR.

Please check whether problems have been caused by your change specifically, as the builds can include changes from many authors. It is not uncommon for your change to be included in a build that fails due to someone else's changes, or infrastructure issues.

How to do this, and the rest of the post-merge process, is covered in detail here.

If your change does cause a problem, it may be reverted, or you can revert it yourself. This is a normal part of LLVM development. You can fix your changes and open a new PR to merge them again.

If you don't get any reports, no action is required from you. Your changes are working as expected, well done!

@Meinersbur
Copy link
Member

Well yes but i don't have enough permissions to merge.

I didn't know. Additional changes are find, I just merged it. Thanks for the patch.

@llvm-ci
Copy link
Collaborator

llvm-ci commented Jun 18, 2025

LLVM Buildbot has detected a new failure on builder clang-m68k-linux-cross running on suse-gary-m68k-cross while building clang at step 5 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/11766

Here is the relevant piece of the build log for the reference
Step 5 (ninja check 1) failure: stage 1 checked (failure)
...
[97/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/TemplateNameTest.cpp.o
[98/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterVisibilityTest.cpp.o
[99/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTTraverserTest.cpp.o
[100/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/DeclPrinterTest.cpp.o
[101/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/FixItTest.cpp.o
[102/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/TypePrinterTest.cpp.o
[103/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterODRStrategiesTest.cpp.o
[104/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/RecursiveASTVisitorTest.cpp.o
[105/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RangeSelectorTest.cpp.o
[106/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterTest.cpp.o
FAILED: tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterTest.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/tools/clang/unittests -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/tools/clang/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests/Tooling -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/third-party/unittest/googletest/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -O3 -DNDEBUG -std=c++17  -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterTest.cpp.o -MF tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterTest.cpp.o.d -o tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterTest.cpp.o -c /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests/AST/ASTImporterTest.cpp
c++: fatal error: Killed signal terminated program cc1plus
compilation terminated.
[107/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/LexicallyOrderedRecursiveASTVisitorTest.cpp.o
[108/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RecursiveASTVisitorTests/Attr.cpp.o
[109/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/SourceLocationTest.cpp.o
[110/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/StructuralEquivalenceTest.cpp.o
[111/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/SourceCodeBuildersTest.cpp.o
[112/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/CodeGen/CodeGenExternalTest.cpp.o
In file included from /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests/CodeGen/CodeGenExternalTest.cpp:21:
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::UnusedFileScopedDecls’ [-Wattributes]
  839 | class Sema final : public SemaBase {
      |       ^~~~
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::TentativeDefinitions’ [-Wattributes]
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::ExtVectorDecls’ [-Wattributes]
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::DelegatingCtorDecls’ [-Wattributes]
[113/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Serialization/NoCommentsTest.cpp.o
[114/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/RefactoringCallbacksTest.cpp.o
[115/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/AST/ASTImporterGenericRedeclTest.cpp.o
[116/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Tooling/SourceCodeTest.cpp.o
[117/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Frontend/NoAlterCodeGenActionTest.cpp.o
[118/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Sema/GslOwnerPointerInference.cpp.o
[119/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/CodeGen/BufferSourceTest.cpp.o
In file included from /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests/CodeGen/BufferSourceTest.cpp:18:
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::UnusedFileScopedDecls’ [-Wattributes]
  839 | class Sema final : public SemaBase {
      |       ^~~~
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::TentativeDefinitions’ [-Wattributes]
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::ExtVectorDecls’ [-Wattributes]
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::DelegatingCtorDecls’ [-Wattributes]
[120/202] Building CXX object tools/clang/unittests/CMakeFiles/AllClangUnitTests.dir/Sema/SemaNoloadLookupTest.cpp.o
In file included from /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Lookup.h:27,
                 from /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/unittests/Sema/SemaNoloadLookupTest.cpp:17:
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::UnusedFileScopedDecls’ [-Wattributes]
  839 | class Sema final : public SemaBase {
      |       ^~~~
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::TentativeDefinitions’ [-Wattributes]
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/clang/include/clang/Sema/Sema.h:839:7: warning: ‘clang::Sema’ declared with greater visibility than the type of its field ‘clang::Sema::ExtVectorDecls’ [-Wattributes]

@eZWALT
Copy link
Contributor Author

eZWALT commented Jun 19, 2025

Thank you so much @Meinersbur !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" clang:modules C++20 modules and Clang Header Modules clang:openmp OpenMP related changes to Clang clang Clang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants