[bazel] Allow SupportTests to be built remotely and cached #121375
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`SupportTests` fails in the bazel macOS sandbox, because `FileSystemTest.permissions` expects to be able to modify file permissions on some otherwise protected files. Previously this test was marked `local` in bazel, which has additional undesirable effects such as skipping remote build and cache. Tighten the bazel tags to just `no-sandbox`. Note in particular, that this allows the test to build, execute, and cache remotely (if configured). Testing: - Verified this test fails (as expected) on macOS with no tags, and passes with `no-sandbox`. - Verified this test passes when executed remotely (using an Engflow RBE setup) with `no-sandbox`.
|
Reviewers: I don't have merge permissions - so please mash the merge button yourself when you feel appropriate. |
rupprecht
approved these changes
Jan 2, 2025
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SupportTestsfails in the bazel macOS sandbox, becauseFileSystemTest.permissionsexpects to be able to modify filepermissions on some otherwise protected files.
Previously this test was marked
localin bazel, which hasadditional undesirable effects such as skipping remote build and cache.
Tighten the bazel tags to just
no-sandbox. Note in particular, thatthis allows the test to build, execute, and cache remotely (if
configured).
Testing:
passes with
no-sandbox.setup) with
no-sandbox.