Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang] Fixed the missing dependency. #121370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vzakhari
Copy link
Contributor

My local build with the shared libraries is broken.
I suppose this was introduced by #120374.

flang/include/flang/Evaluate/constant.h ends up being included
by MapInfoFinalization.cpp via flang/Lower/DirectivesCommon.h.
The undefined references are related to ConstantBase classes.

My local build with the shared libraries is broken.
I suppose this was introduced by llvm#120374.

`flang/include/flang/Evaluate/constant.h` ends up being included
by `MapInfoFinalization.cpp` via `flang/Lower/DirectivesCommon.h`.
The undefined references are related to `ConstantBase` classes.
@vzakhari vzakhari requested a review from ergawy December 31, 2024 04:54
@llvmbot llvmbot added flang Flang issues not falling into any other category flang:fir-hlfir labels Dec 31, 2024
@llvmbot
Copy link
Member

llvmbot commented Dec 31, 2024

@llvm/pr-subscribers-flang-fir-hlfir

Author: Slava Zakharin (vzakhari)

Changes

My local build with the shared libraries is broken.
I suppose this was introduced by #120374.

flang/include/flang/Evaluate/constant.h ends up being included
by MapInfoFinalization.cpp via flang/Lower/DirectivesCommon.h.
The undefined references are related to ConstantBase classes.


Full diff: https://github.com/llvm/llvm-project/pull/121370.diff

1 Files Affected:

  • (modified) flang/lib/Optimizer/OpenMP/CMakeLists.txt (+1)
diff --git a/flang/lib/Optimizer/OpenMP/CMakeLists.txt b/flang/lib/Optimizer/OpenMP/CMakeLists.txt
index 4f23b2b970fa44..026889cca238a0 100644
--- a/flang/lib/Optimizer/OpenMP/CMakeLists.txt
+++ b/flang/lib/Optimizer/OpenMP/CMakeLists.txt
@@ -22,6 +22,7 @@ add_flang_library(FlangOpenMPTransforms
   FIRDialectSupport
   FIRSupport
   FortranCommon
+  FortranEvaluate
   MLIRFuncDialect
   MLIROpenMPDialect
   HLFIRDialect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flang:fir-hlfir flang Flang issues not falling into any other category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants