Merged
Conversation
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
5 times, most recently
from
736e8a4 to
d243037
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
11 times, most recently
from
a6b71f6 to
7803709
Compare
makslevental
requested review from
PragmaTwice,
ashermancinelli and
rolfmorel
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
from
7803709 to
dcd514f
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
from
dcd514f to
1002be5
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
4 times, most recently
from
33c1453 to
11063f6
Compare
PragmaTwice
approved these changes
Dec 7, 2025
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
from
11063f6 to
db994ac
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
3 times, most recently
from
8d6810e to
6cbbc3c
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
from
6cbbc3c to
dca4f85
Compare
makslevental
force-pushed
the
users/makslevental/enable-wasm-llvm
branch
from
da0b9c2 to
ec0712d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR factors out the LLVM distro portion of the build of
mlir-python-bindings-wasm- i.e., it creates awasm32-empscriptenwheel/distro in addition to our current set of platforms. This is in preparation for #268 which will build out variousmlir-wgputhings on top of this distro.One tedious/weeds thing to call out: just building the distro via cross-compiling (using Emscripten's toolchain) didn't work because
find_package(Python3 Development)fails to successfully find Python dev libs. I believe it has something to do with CMP0190 but I couldn't debug it all the way. Butpyodide buildsucceeds (because it somehow isn't cross-compiling technically???) so that's good enough.In addition some drive-by cleanup (remove
macos-13from the GHA workflows).