[CIR][Transforms] Fix flattening for TryOp with empty catch region #1646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the following code snippet crashes during flattening, before lowering to llvm:
Command to reproduce:
The crash happens when flattening a TryOp with an empty catch region and building catchers. Something like:
the crash happens at
tryOp.isCatchAllOnly()
to be specific, because the catch types attribute list is empty.The fix is simple - adding a check for an empty/non-existent catch region before building the catch clauses.
This PR adds this fix and one test.
Side-note: This enables
push_back
forstd::vector
to be lowered to llvm, for example: