Skip to content

Add CPU FGMRES support and correct BlockSchur factorization - #1680

Open
chvillanuevap wants to merge 2 commits into
developfrom
review/flow-solver-essentials
Open

chvillanuevap wants to merge 2 commits into
developfrom
review/flow-solver-essentials

Conversation

@chvillanuevap

Copy link
Copy Markdown
Member

Summary

This PR introduces two independent improvements to Smith's linear solver infrastructure:

  1. CPU FGMRES and configurable restart length

    • Exposes native MFEM FGMRES through Smith's solver factory.
    • Adds configurable Krylov restart dimensions for GMRES and FGMRES.
    • Includes factory, configuration, and solver tests.
  2. BlockSchur factorization correction

    • Eliminates redundant application of the first-block inverse in lower/full factorization.
    • Preserves the previously computed velocity inverse result.
    • Adds tests for block algebra, in-place application, and inverse application counts.

Validation

  • 395 tests passed across the three affected test executables.
  • Both commits were checked for integration conflicts with Roy's custom-Schur branches. No production-code conflicts were identified; combined compilation remains pending.

Scope

This PR does not introduce new custom-Schur APIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant