code optimization

main.py

@@ -1,31 +1,25 @@
-import scriptabsen
 import values
+import scriptabsen as script
 import pytz
-from time import time, sleep
+import time
 from datetime import datetime
 
 print("Ready")
 
 while True:
-    sleep(5 - time() % 5)
-
+    time.sleep(5)
     WIB = pytz.timezone('Asia/Jakarta')
     time_now = datetime.now(WIB)
 
-    if (time_now.strftime('%H') == '05' and
-            time_now.strftime('%M') == '58' and
-            time_now.strftime('%a') != 'Sat' and
-            time_now.strftime('%a') != 'Sun'):
-        temp = scriptabsen.runscript(values.email(), values.password(), values.browser())
+    if time_now.strftime('%H') == '05' and time_now.strftime('%M') == '58' and time_now.strftime('%a') != 'Sat' and time_now.strftime('%a') != 'Sun':
+        temp = script.runscript(values.email, values.password, values.browser())
         times = datetime.now(WIB)
         if(temp == True):
-            print("Absen berhasil pada " + times.strftime('%c'))
+            print("Absen berhasil pada", times.strftime('%c'))
         elif(temp == False):
-            print("Absen gagal, SERVER SEKOLAH KENTANK, mencoba lagi " +
+            print("Absen gagal, SERVER SEKOLAH KENTANK, mencoba lagi",
                   times.strftime('%c'))
-            ass = scriptabsen.override(values.email(), values.password(), values.browser())
-            if ass == True:
-                timee = datetime.now(WIB)
-                print("Absen berhasil pada " + timee.strftime('%c'))
+            if script.override(values.email, values.password, values.browser()) == True:
+                print("Absen berhasil pada " + datetime.now(WIB).strftime('%c'))
         else:
             print("Server-mu Down " + times.strftime('%c'))

scriptabsen.py

@@ -1,7 +1,5 @@
-from selenium import webdriver
 import pytz
 import time
-from time import sleep
 from datetime import datetime
 
 
@@ -27,13 +25,10 @@ def runscript(email, password, browser):
     browser.get("https://siswa.smktelkom-mlg.sch.id/presnow")
 
     while True:
-        WIB = pytz.timezone('Asia/Jakarta')
-        time_now = datetime.now(WIB)
-        if time_now.strftime('%H') == '06' and time_now.strftime('%M') == '00':
-            browser.refresh()
+        time_now = datetime.now(pytz.timezone('Asia/Jakarta'))
+        if time_now.strftime('%H') == '06':
             if cek_absen(browser) == False:
                 absen(browser)
-                browser.refresh()
                 if cek_absen(browser) == True:
                     logout(browser)
                     return True
@@ -54,6 +49,7 @@ def absen(browser):
 
 
 def cek_absen(browser):
+    browser.refresh()
     tmp = browser.find_element_by_class_name('number')
     if(tmp.text == 'Masuk'):
         return True
@@ -68,6 +64,5 @@ def logout(browser):
 
 def override(email, password, browser):
     while True:
-        data = runscript(email, password, browser)
-        if data == True:
+        if runscript(email, password, browser) == True:
             return True

values.py

@@ -4,20 +4,12 @@
 #
 #
 # Emailmu Si AKAD blyat
-Email = ""
+email = ""
 #
 #
 #
 # Passwordmu Si AKAD blyat
-Password = ""
-
-
-def email():
-    return Email
-
-
-def password():
-    return Password
+password = ""
 
 def browser():
     chromes = webdriver.ChromeOptions()