Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#206 bugfix object_id in CalendarRelation #207

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

rodolphopivetta
Copy link

Format of object_id in CalendarRelation changed to accept UUID pk, based on documentation

@coveralls
Copy link

coveralls commented May 17, 2016

Coverage Status

Coverage remained the same at 65.345% when pulling 30cdd6c on rodolphopivetta:master into a084322 on llazzaro:develop.

@llazzaro
Copy link
Owner

llazzaro commented May 18, 2016

I think you miss to send the migrations.
Please remember that if required a data migration is also required since a lot of people is using this project.
thanks!

rodolpho.pivetta added 2 commits May 18, 2016 10:17
@rodolphopivetta
Copy link
Author

Sorry, migrations added :)

@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 65.345% when pulling 1c78487 on rodolphopivetta:master into a084322 on llazzaro:develop.

@coveralls
Copy link

coveralls commented May 18, 2016

Coverage Status

Coverage remained the same at 65.345% when pulling 1c78487 on rodolphopivetta:master into a084322 on llazzaro:develop.

@coveralls
Copy link

coveralls commented May 29, 2016

Coverage Status

Coverage increased (+1.4%) to 66.723% when pulling ab14575 on rodolphopivetta:master into a084322 on llazzaro:develop.

@llazzaro
Copy link
Owner

I didn't have time to verify with a production database backup. Hope to do it soon

@jdufresne
Copy link
Collaborator

@rodolphopivetta Will this change have an affect on performance for integer PK fields?

@jdufresne
Copy link
Collaborator

No activity in over a year and there. There are merge conflicts and unanswered review question. I'm closing. If you would like to continue the PR, please answer the above questions and rebase to resolve conflicts. Thanks.

@jdufresne jdufresne closed this Jan 9, 2018
@vegerta
Copy link

vegerta commented Jul 7, 2018

Can we reopen this pull?

@llazzaro
Copy link
Owner

llazzaro commented Jul 7, 2018

@vegerta are you having this bug? can tell us how to reproduce it?

@vegerta
Copy link

vegerta commented Jul 8, 2018

You can reproduce it, if you make a fresh install and create a model(for expamle: Workers) where you defined the deafult Id field as UUIDField. And when you can try to add some calendar relation you can't save ID value.

@llazzaro llazzaro reopened this Dec 28, 2018
@llazzaro
Copy link
Owner

I will try to review this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants