refactor(PGVector): wrap gin index creation into a separate function#4980
Open
r3v5 wants to merge 1 commit intollamastack:mainfrom
Open
refactor(PGVector): wrap gin index creation into a separate function#4980r3v5 wants to merge 1 commit intollamastack:mainfrom
r3v5 wants to merge 1 commit intollamastack:mainfrom
Conversation
r3v5
requested review from
ashwinb,
bbrowning,
cdoern,
ehhuang,
franciscojavierarceo,
leseb,
mattf and
raghotham
as code owners
meta-cla
bot
added
the
CLA Signed
r3v5
force-pushed
the
wrap-gin-index-creation-into-separate-function
branch
2 times, most recently
from
495cf0d to
16538bd
Compare
r3v5
changed the title
r3v5
force-pushed
the
wrap-gin-index-creation-into-separate-function
branch
7 times, most recently
from
9fc6fdc to
f2f2508
Compare
ChristianZaccaria
suggested changes
Feb 25, 2026
Contributor
ChristianZaccaria
left a comment
ChristianZaccaria
left a comment
There was a problem hiding this comment.
Looks good! I just left a couple of comments.
tests/unit/providers/vector_io/test_vector_io_openai_vector_stores.py
Outdated
Show resolved
Hide resolved
src/llama_stack/providers/remote/vector_io/pgvector/pgvector.py
Outdated
Show resolved
Hide resolved
r3v5
force-pushed
the
wrap-gin-index-creation-into-separate-function
branch
4 times, most recently
from
b37b655 to
17b53f6
Compare
r3v5
force-pushed
the
wrap-gin-index-creation-into-separate-function
branch
from
17b53f6 to
30fc65c
Compare
Contributor
derekhiggins
left a comment
derekhiggins
left a comment
There was a problem hiding this comment.
lgtm, not sure we need both test_create_gin_index_executes_correct_sql and test_gin_index_creation_in_initialize_call but thats just me :-)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR is responsible for refactoring GIN index creation in pgvector wrapping creation logic into a separate function that is being called within
initialize(self)inPGVectorIndexImpact: makes code more modular, extendable and simplifies testing.
Test Plan
Added unit tests and existing CI