Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lkl: update CI images on circleci #567

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

thehajime
Copy link
Member

this contains a fix for android build (arm64) of missing preadv/pwritev symbols.

@thehajime
Copy link
Member Author

dunno why circleci doesn't show up with this pull request...
currently debugging this.

@thehajime thehajime marked this pull request as ready for review February 19, 2025 02:24
this contains a fix for android build (arm64) of missing preadv/pwritev
symbols.

Signed-off-by: Hajime Tazaki <[email protected]>
@thehajime
Copy link
Member Author

unfortunately, the new arm64 image (v1.4) cannot execute arm64 emulator (qemu) as the same Dockerfile didn't install the same emulator version, and newer emulator doesn't support arm64 guest on x86_64..
if we use the base image with older version (android:v1.3) for arm64 image, it works.

I would keep open this PR for the moment while fixing the issue by re-generating circleci image (another PR on lkl/lkl-docker). Will be back once I got a workaround.

@thehajime
Copy link
Member Author

the test looks good; asking for a review @tavip

Copy link

@ddiss ddiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the images!

Copy link
Member

@tavip tavip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @thehajime !

@thehajime thehajime merged commit 1f42eb4 into lkl:master Feb 20, 2025
14 checks passed
@thehajime thehajime deleted the bump-circleci-img branch February 20, 2025 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants