-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add --names option #67
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the const metrics =
code can be moved down, to right above where the table is generated.
i then also wonder if maybe the code that gets, filters, and sorts repositories
could live in a separate function that detail
calls? and then, we could have repo-report --names
call that directly instead of adding this to detail?
What do you think about #67 (review) ? |
I think it's o-kay for now. |
That's true that it's the bulk of the detail command - but the "generateDetailTable" call is really the point of that, getting repo names is incidental. I'm happy to land this as-is, but I'll probably refactor it this way anyways :-) |
Aight. Perhaps I can open a separate issue addressing this once the current PR is merged? |
f466e04
to
8d97bd6
Compare
Turns out we already had |
Woah! Just saw your refactored code 🙌 |
solves #50, by adding the
--names
option.On setting
true
it outputs the list ofrepos-with-their owner
instead of therepo-report
table.will remove the alias if it's not required here, or can come up with a more meaningful name for the option
cc: @ljharb