Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add square brackets to prefixes with arrayFormat: comma #316

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Add square brackets to prefixes with arrayFormat: comma #316

wants to merge 1 commit into from

Conversation

sanex3339
Copy link

@sanex3339 sanex3339 commented Jun 4, 2019 •
edited by ljharb
Loading

Fixes #315.

@sanex3339 sanex3339 mentioned this pull request Jun 4, 2019
Open
@sanex3339

This comment has been minimized.

Sign in to view
ljharb
ljharb requested changes Aug 16, 2019
View reviewed changes
Copy link
Owner

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be a breaking change. It seems to be what's requested in #327, however.

@aribouius
Copy link

Any update on this?

@jorgandia
Copy link

Hi! Are you thinking about merging this pr at any point?

Thanks!

@ljharb
Copy link
Owner

ljharb commented Jul 19, 2020

@jorgandia since it's semver-major, i'm planning to merge it whenever there's a semver-major planned. At the moment, none is planned.

@ljharb ljharb marked this pull request as draft September 16, 2023 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
semver-major: breaking change stringify
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stringify with comma format should add square brackets to parameter name to identity array with single value
4 participants
@sanex3339 @aribouius @jorgandia @ljharb