Refactor getRealRowCountTable

Signed-off-by: Liviu-Mihail Concioiu <[email protected]>

src/Controllers/Database/Structure/RealRowCountController.php

@@ -55,7 +55,7 @@ public function __invoke(ServerRequest $request): Response
         // If there is a request to update all table's row count.
         if (! isset($parameters['real_row_count_all'])) {
             // Get the real row count for the table.
-            $realRowCount = (int) $this->dbi
+            $realRowCount = $this->dbi
                 ->getTable(Current::$database, (string) $parameters['table'])
                 ->getRealRowCountTable();
             // Format the number.
@@ -70,7 +70,7 @@ public function __invoke(ServerRequest $request): Response
         $realRowCountAll = [];
         // Iterate over each table and fetch real row count.
         foreach ($this->dbi->getTables(Current::$database) as $table) {
-            $rowCount = (int) $this->dbi
+            $rowCount = $this->dbi
                 ->getTable(Current::$database, $table)
                 ->getRealRowCountTable();
             $realRowCountAll[] = ['table' => $table, 'row_count' => Util::formatNumber($rowCount, 0)];

src/Table/Table.php

@@ -1742,23 +1742,12 @@ public function showCreate(): string
     /**
      * Returns the real row count for a table
      */
-    public function getRealRowCountTable(): int|null
+    public function getRealRowCountTable(): int
     {
-        // SQL query to get row count for a table.
-        $result = $this->dbi->fetchSingleRow(
-            sprintf(
-                'SELECT COUNT(*) AS %s FROM %s.%s',
-                Util::backquote('row_count'),
-                Util::backquote($this->dbName),
-                Util::backquote($this->name),
-            ),
+        return (int) $this->dbi->fetchValue(
+            'SELECT COUNT(*) FROM ' . Util::backquote($this->dbName) . '.'
+            . Util::backquote($this->name)
         );
-
-        if ($result === []) {
-            return null;
-        }
-
-        return (int) $result['row_count'];
     }
 
     /**